Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed increase for OSV, GitHub provider work, Documentation Update #249

Merged
merged 8 commits into from
Sep 23, 2024

Conversation

djschleen
Copy link
Member

@djschleen djschleen commented Sep 21, 2024

  • Provider renamed to github
  • Initial mapping to of advisories to bomber vulnerability struct
  • Updated documentation
  • Major overhaul and performance boost for OSV provider. It's lightning fast now.
  • Adds ecosystem warnings if there are ecosystems that are not supported by the chosen provider
  • Fixes an issue where versions were not being passed to Providers

@djschleen djschleen changed the title Update launch.json and gad.go. Speed increase for OSV, GitHub provider work, Documentation Update Sep 23, 2024
@djschleen djschleen self-assigned this Sep 23, 2024
@djschleen djschleen added bug Something isn't working enhancement New feature or request labels Sep 23, 2024
mirxcle
mirxcle previously approved these changes Sep 23, 2024
This commit adds the SupportedEcosystems method to the Provider interface in the models package. The method returns a slice of strings representing the supported ecosystems by the provider. This change allows providers to declare the ecosystems they support, which can be used for validation and information display.
@mirxcle mirxcle marked this pull request as ready for review September 23, 2024 15:31
mirxcle
mirxcle previously approved these changes Sep 23, 2024
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 4.65116% with 164 lines in your changes missing coverage. Please review.

Project coverage is 65.81%. Comparing base (f6fbbaf) to head (26f9319).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
providers/osv/osv.go 0.00% 76 Missing ⚠️
providers/gad/gad.go 7.50% 37 Missing ⚠️
providers/snyk/snyk.go 0.00% 17 Missing ⚠️
providers/ossindex/OSSIndex.go 0.00% 16 Missing ⚠️
lib/scanner.go 0.00% 9 Missing and 1 partial ⚠️
cmd/root.go 0.00% 8 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #249       +/-   ##
===========================================
- Coverage   76.67%   65.81%   -10.87%     
===========================================
  Files          27       28        +1     
  Lines        1402     1562      +160     
===========================================
- Hits         1075     1028       -47     
- Misses        295      504      +209     
+ Partials       32       30        -2     
Flag Coverage Δ
65.81% <4.65%> (-10.87%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@djschleen djschleen merged commit 692b3e4 into main Sep 23, 2024
3 of 5 checks passed
@djschleen djschleen deleted the ghsd-wip branch September 23, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
2 participants