Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#770: Less VPN shell text Fix mv folder with space #792

Merged

Conversation

cinnamon-coder-hub
Copy link
Member

@cinnamon-coder-hub cinnamon-coder-hub commented Jun 10, 2022

Improvements for docker commandlet with RancherDesktop:

  • quote path args to avoid errors if path contains spaces
  • improvement and simplification to VPNKit setup therefore also better UX for end-users

@github-actions github-actions bot added bash related to bash shell or scripts commandlet related to commandlets (scripts/command/*) scripts related to shell scripts (bash and CMD) labels Jun 10, 2022
@hohwille hohwille added this to the release:2022.04.003 milestone Jun 10, 2022
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cinnamon-coder-hub Thank you for this PR. All improvements look good to me 👍

@hohwille hohwille merged commit 0812921 into devonfw:master Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bash related to bash shell or scripts commandlet related to commandlets (scripts/command/*) scripts related to shell scripts (bash and CMD)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RancherDesktop can not be installed Add VPN enhancement to RancherDesktop
2 participants