#758: add status commandlet #770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved the method postInstall from GlobalToolCommandlet to LocalToolCommandlet and changed the installation message so that the user is not getting confused
Added a status commandlet that lets the user check his ide status
…com/leonrohne27/IDEasy into implement/758-add-status-commandlet
Pull Request Test Coverage Report for Build 12020768307Details
💛 - Coveralls |
jan-vcapgemini
changed the title
jan-vcapgemini
requested changes
Nov 18, 2024
cli/src/main/java/com/devonfw/tools/ide/commandlet/StatusCommandlet.java
Show resolved
Hide resolved
cli/src/main/java/com/devonfw/tools/ide/commandlet/StatusCommandlet.java
Outdated
Show resolved
Hide resolved
cli/src/main/java/com/devonfw/tools/ide/commandlet/StatusCommandlet.java
Outdated
Show resolved
Hide resolved
Co-authored-by: jan-vcapgemini <[email protected]>
added missing Javadoc to StatusCommandlet and updated help output
…com/leonrohne27/IDEasy into implement/758-add-status-commandlet # Conflicts: # cli/src/main/resources/nls/Help_de.properties
jan-vcapgemini
approved these changes
Nov 18, 2024
hohwille
reviewed
Nov 20, 2024
hohwille
approved these changes
Nov 20, 2024
There was a problem hiding this comment.
@leonrohne27 thanks for your PR. Nice feature showing how simple it can be to bring a helpful new feature to IDEasy. 👍
I left a review comment for discussion. You did nothing wrong here and I did not think of that when writing the story but may be worth to discuss and consider before merging.
|
CHANGELOG entry was missing and help texts need some rework but already merged. Will do that later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #758
Implements:
Added a status commandlet that lets the user check his ide-status