-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#751: Moved postInstall() and changed tool installation message #763
#751: Moved postInstall() and changed tool installation message #763
Conversation
Moved the method postInstall from GlobalToolCommandlet to LocalToolCommandlet and changed the installation message so that the user is not getting confused
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Ready for review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@leonrohne27 thanks for your PR. You solved the second task of #751 nicely. 👍
For the first task there is a slight misunderstanding - sorry, if I was not precise enough:
Move postInstall() to LocalToolCommandlet and remove it from [Global]ToolCommandlet:
I expect that the postInstall
method(s) (with its body/implementation) gets moved to LocalToolCommandlet
. If GlobalToolCommandlet
does not support postInstall
, then it does not make sense anymore if it has a method postInstall
.
It is fully correct that you removed the invocation of postInstall()
from GlobalToolCommandlet
but you also need to move postInstall()
and postInstall(boolean)
from ToolCommandlet
to LocalToolCommandlet
.
Then sub-classes of GlobalToolCommandlet
cannot override postInstall
anymore and since we always use @Override
annotations in such case, we would even get compile errors if we missed something.
Please have a look and update your PR. Thanks.
cli/src/main/java/com/devonfw/tools/ide/tool/LocalToolCommandlet.java
Outdated
Show resolved
Hide resolved
…et.java Co-authored-by: Jörg Hohwiller <[email protected]>
Pull Request Test Coverage Report for Build 11888068434Details
💛 - Coveralls |
moved postInstall() from ToolCommandlet to LocalToolCommandlet
…github.com/leonrohne27/IDEasy into fix/751-small-cleanup-globaltoolcommandlet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@leonrohne27 thanks for rework, ready for merge now 👍
Fixes: #751
Implements: