Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#81: Implement ToolCommandlet for Kubernetes #702

Merged
merged 37 commits into from
Nov 25, 2024
Merged

#81: Implement ToolCommandlet for Kubernetes #702

merged 37 commits into from
Nov 25, 2024
+107 −0

Conversation

KianRolf
Copy link
Contributor

@KianRolf KianRolf commented Oct 18, 2024 •
edited
Loading

fixes #81 ToolCommandlet for Kubernetes.

Discussion:

  • Has no test, since it is a GlobalToolCommandlet.

@KianRolf KianRolf self-assigned this Oct 18, 2024
@coveralls
Copy link
Collaborator

coveralls commented Oct 18, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11892982640

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.006%) to 67.276%
Files with Coverage Reduction New Missed Lines %
com/devonfw/tools/ide/commandlet/CommandletManagerImpl.java 3 90.43%
Totals Coverage Status
Change from base Build 11853076778: -0.006%
Covered Lines: 6406
Relevant Lines: 9181
💛 - Coveralls

hohwille
hohwille requested changes Oct 18, 2024
View reviewed changes
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KianRolf thanks for implementing #81.
You properly implemented the steps to create a new commandlet. 👍
I left some comments to improve and we still need some discussion here to complete this.

cli/src/main/java/com/devonfw/tools/ide/tool/kubectl/KubeCtl.java Outdated Show resolved Hide resolved
cli/src/main/java/com/devonfw/tools/ide/tool/kubectl/KubeCtl.java Outdated Show resolved Hide resolved
cli/src/main/resources/nls/Help_de.properties Outdated Show resolved Hide resolved
cli/src/main/resources/nls/Help_de.properties Outdated Show resolved Hide resolved
cli/src/main/resources/nls/Help.properties Outdated Show resolved Hide resolved
@jan-vcapgemini jan-vcapgemini mentioned this pull request Oct 21, 2024
Closed
KianRolf and others added 16 commits October 21, 2024 12:48
@KianRolf
Merge branch 'devonfw:main' into implement/81-kubectl-comandlet
6518595
@KianRolf @hohwille
Update cli/src/main/java/com/devonfw/tools/ide/tool/kubectl/KubeCtl.java
7b4d6e7 
Co-authored-by: Jörg Hohwiller <[email protected]>
@KianRolf @hohwille
Update cli/src/main/resources/nls/Help_de.properties
2c8a4c7 
Co-authored-by: Jörg Hohwiller <[email protected]>
@KianRolf @hohwille
Update cli/src/main/resources/nls/Help_de.properties
5a59b83 
Co-authored-by: Jörg Hohwiller <[email protected]>
@KianRolf @hohwille
Update cli/src/main/resources/nls/Help.properties
8aa75a4 
Co-authored-by: Jörg Hohwiller <[email protected]>
@KianRolf
Merge branch 'main' into implement/81-kubectl-comandlet
1de727b
@KianRolf
devonfw#81: Correction
42da84f
@KianRolf
Merge branch 'main' of https://github.com/KianRolf/IDEasy
e520d16
@KianRolf
Merge branch 'main' of https://github.com/KianRolf/IDEasy
29403d3
@KianRolf
Merge branch 'main' of https://github.com/KianRolf/IDEasy
5bff5eb
@jan-vcapgemini
Merge branch 'main' into implement/81-kubectl-comandlet
f56b1f4
@KianRolf
Merge branch 'main' of https://github.com/KianRolf/IDEasy
890c107
@KianRolf
Merge branch 'main' into implement/81-kubectl-comandlet
ceb4d55
@KianRolf
devonfw#81: Delegating commandlet
a5356a6
@KianRolf
Merge branch 'main' into implement/81-kubectl-comandlet
5d28bf6
@KianRolf
Merge branch 'implement/81-kubectl-comandlet' of https://github.com/K…
e496fbb 
…ianRolf/IDEasy into implement/81-kubectl-comandlet
jan-vcapgemini
jan-vcapgemini requested changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@jan-vcapgemini jan-vcapgemini left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for you implementation of the kubectl commandlet. Please add an install and run test for kubectl too. I've added some CRs (mostly missing javadocs)

cli/src/main/java/com/devonfw/tools/ide/tool/DelegatingToolCommandlet.java Outdated Show resolved Hide resolved
cli/src/main/java/com/devonfw/tools/ide/tool/DelegatingToolCommandlet.java Outdated Show resolved Hide resolved
cli/src/main/java/com/devonfw/tools/ide/tool/DelegatingToolCommandlet.java Outdated Show resolved Hide resolved
cli/src/main/java/com/devonfw/tools/ide/tool/kubectl/KubeCtl.java Show resolved Hide resolved
@jan-vcapgemini jan-vcapgemini self-assigned this Nov 4, 2024
jan-vcapgemini
jan-vcapgemini approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@jan-vcapgemini jan-vcapgemini left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please check CRs for last cleanups.

cli/src/main/java/com/devonfw/tools/ide/tool/DelegatingToolCommandlet.java Outdated Show resolved Hide resolved
CHANGELOG.adoc Outdated Show resolved Hide resolved
jan-vcapgemini
jan-vcapgemini approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@jan-vcapgemini jan-vcapgemini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, ready for review.

hohwille
hohwille approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KianRolf thanks for the PR and updates. 👍
I left 2 comments for rework.
After addressing them this is ready for merge.

cli/src/main/java/com/devonfw/tools/ide/tool/DelegatingToolCommandlet.java Outdated Show resolved Hide resolved
cli/src/main/java/com/devonfw/tools/ide/tool/kubectl/KubeCtl.java Outdated Show resolved Hide resolved
@hohwille hohwille added this to the release:2024.12.001 milestone Nov 25, 2024
@hohwille hohwille merged commit a667129 into devonfw:main Nov 25, 2024
3 checks passed
@hohwille hohwille added reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented. docker docker and esp. DockerDesktop kubectl labels Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan-vcapgemini jan-vcapgemini jan-vcapgemini approved these changes

@hohwille hohwille hohwille approved these changes

Assignees

@hohwille hohwille

@KianRolf KianRolf

Labels
commandlet docker docker and esp. DockerDesktop kubectl reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented.
Projects
IDEasy board
Status: ✅ Done
Milestone
release:2024.12.001
Development

Successfully merging this pull request may close these issues.

Implement ToolCommandlet for Kubernetes
4 participants
@KianRolf @coveralls @hohwille @jan-vcapgemini