Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#315: Fix frozen process after global tool installation with msiexec #684

Merged
merged 12 commits into from
Nov 11, 2024
Merged

#315: Fix frozen process after global tool installation with msiexec #684

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
a1efd4a
#315: Fix frozen process after MSI installation
alfeilex Oct 9, 2024
edec8e4
Merge branch 'main' into #315-bugfixDocker
alfeilex Oct 10, 2024
993a0ae
Update changelog
alfeilex Oct 10, 2024
ec0d22b
Merge branch '#315-bugfixDocker' of https://github.com/alfeilex/IDEas…
alfeilex Oct 10, 2024
14e7c6f
fix type
alfeilex Oct 10, 2024
a745d2a
Merge branch 'main' into #315-bugfixDocker
jan-vcapgemini Oct 15, 2024
5c2fc5f
Merge branch 'devonfw:main' into #315-bugfixDocker
alfeilex Oct 15, 2024
1ee8d4a
revert qn argument and change processmode of run of global tools to b…
alfeilex Oct 29, 2024
96ee7f6
Merge branch 'main' into #315-bugfixDocker
alfeilex Oct 29, 2024
7183c9d
Merge branch 'devonfw:main' into #315-bugfixDocker
alfeilex Oct 30, 2024
e65715e
Merge branch 'main' into #315-bugfixDocker
alfeilex Nov 4, 2024
13944f6
Merge branch 'main' into #315-bugfixDocker
hohwille Nov 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ The full list of changes for this release can be found in https://github.com/dev

Release with new features and bugfixes:

* https://github.com/devonfw/IDEasy/issues/315[#315]: Fix frozen process after MSI installation
* https://github.com/devonfw/IDEasy/issues/312[#312]: Add ability to prefer git (ssh) protocol instead of https for cloning repo
* https://github.com/devonfw/IDEasy/issues/685[#685]: Upgrades and cleanup of dependencies and according license and doc
* https://github.com/devonfw/IDEasy/pull/693[#693]: Setup not working on Mac
Expand Down
3 changes: 2 additions & 1 deletion cli/src/main/java/com/devonfw/tools/ide/tool/GlobalToolCommandlet.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
import com.devonfw.tools.ide.process.EnvironmentContext;
import com.devonfw.tools.ide.process.ProcessContext;
import com.devonfw.tools.ide.process.ProcessErrorHandling;
import com.devonfw.tools.ide.process.ProcessMode;
import com.devonfw.tools.ide.repo.ToolRepository;
import com.devonfw.tools.ide.version.VersionIdentifier;

Expand Down Expand Up @@ -141,7 +142,7 @@ public boolean install(boolean silent, EnvironmentContext environmentContext) {
executable = fileAccess.findFirst(downloadBinaryPath, Files::isExecutable, false);
}
ProcessContext pc = this.context.newProcess().errorHandling(ProcessErrorHandling.LOG_WARNING).executable(executable);
int exitCode = pc.run();
int exitCode = pc.run(ProcessMode.BACKGROUND).getExitCode();
hohwille marked this conversation as resolved.
Show resolved Hide resolved
if (tmpDir != null) {
fileAccess.delete(tmpDir);
}
Expand Down
Loading