Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#557: fix json mapping #617

Merged
merged 7 commits into from
Sep 17, 2024
Merged

Conversation

hohwille
Copy link
Member

fixes #557

@hohwille hohwille self-assigned this Sep 13, 2024
@hohwille hohwille added bugfix urls ide-urls repo and related processes and features labels Sep 13, 2024
@hohwille hohwille added this to the release:2024.09.002 milestone Sep 13, 2024
@coveralls
Copy link
Collaborator

coveralls commented Sep 13, 2024

Pull Request Test Coverage Report for Build 10899783105

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 14 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.02%) to 65.675%

Files with Coverage Reduction New Missed Lines %
com/devonfw/tools/ide/version/VersionIdentifier.java 1 86.09%
com/devonfw/tools/ide/version/VersionRange.java 13 83.0%
Totals Coverage Status
Change from base Build 10888946544: -0.02%
Covered Lines: 5996
Relevant Lines: 8796

💛 - Coveralls

Copy link
Contributor

@jan-vcapgemini jan-vcapgemini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Added a short question.

Copy link
Contributor

@slskiba slskiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Since you created the json package, it might be plausible to also move the JsonObject and JsonVersionItem classes there. Even though they are not functionally connected , those two classes currently lie in common, and json just seems like the better choice here.

@hohwille
Copy link
Member Author

Since you created the json package, it might be plausible to also move the JsonObject and JsonVersionItem classes there. Even though they are not functionally connected , those two classes currently lie in common, and json just seems like the better choice here.

Done.

@hohwille hohwille merged commit b8cbd38 into devonfw:main Sep 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix urls ide-urls repo and related processes and features
Projects
Status: ✅ Done
4 participants