-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#557: fix json mapping #617
Conversation
Pull Request Test Coverage Report for Build 10899783105Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Added a short question.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Since you created the json
package, it might be plausible to also move the JsonObject
and JsonVersionItem
classes there. Even though they are not functionally connected , those two classes currently lie in common
, and json
just seems like the better choice here.
Done. |
fixes #557