-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#438: validationstate #569
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 10777736263Details
💛 - Coveralls |
hohwille
reviewed
Sep 3, 2024
cli/src/main/java/com/devonfw/tools/ide/commandlet/InstallCommandlet.java
Outdated
Show resolved
Hide resolved
hohwille
reviewed
Sep 3, 2024
hohwille
reviewed
Sep 3, 2024
cli/src/main/java/com/devonfw/tools/ide/commandlet/Commandlet.java
Outdated
Show resolved
Hide resolved
add joining of ValidationResults
…iba/IDEasy into feature/438-validationstate
hohwille
approved these changes
Sep 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@slskiba thanks for your rework. You created a solid state and are almost there. 👍
I left some comments to guide the way.
Once addressed, we can finally merge.
cli/src/main/java/com/devonfw/tools/ide/validation/ValidationState.java
Outdated
Show resolved
Hide resolved
cli/src/main/java/com/devonfw/tools/ide/commandlet/Commandlet.java
Outdated
Show resolved
Hide resolved
cli/src/main/java/com/devonfw/tools/ide/context/AbstractIdeContext.java
Outdated
Show resolved
Hide resolved
hohwille
reviewed
Sep 5, 2024
cli/src/main/java/com/devonfw/tools/ide/commandlet/Commandlet.java
Outdated
Show resolved
Hide resolved
hohwille
reviewed
Sep 5, 2024
hohwille
added
the
reviewed
Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented.
label
Sep 24, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
reviewed
Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #438. added exemplary usage to
InstallCommandlet
TBD:
InstallCommandlet
checks whether the given version is a valid one - this is a relevant check for aVersionProperty
at any given place - should they now each implement an identical validator?PathProperty
solves this by overridingvalidate()
, to implement general Path-related validation - or should this move into validator implementations?