Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#438: validationstate #569

Merged
merged 12 commits into from
Sep 9, 2024
Merged

Conversation

slskiba
Copy link
Contributor

@slskiba slskiba commented Aug 30, 2024

Closes #438. added exemplary usage to InstallCommandlet

TBD:

  • Exemplary usage added in InstallCommandlet checks whether the given version is a valid one - this is a relevant check for a VersionProperty at any given place - should they now each implement an identical validator?
  • PathProperty solves this by overriding validate(), to implement general Path-related validation - or should this move into validator implementations?

@slskiba slskiba self-assigned this Aug 30, 2024
@coveralls
Copy link
Collaborator

coveralls commented Aug 30, 2024

Pull Request Test Coverage Report for Build 10777736263

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 134 unchanged lines in 14 files lost coverage.
  • Overall coverage increased (+0.05%) to 65.656%

Files with Coverage Reduction New Missed Lines %
com/devonfw/tools/ide/property/StringProperty.java 1 88.89%
com/devonfw/tools/ide/property/EditionProperty.java 1 83.33%
com/devonfw/tools/ide/url/model/file/UrlDependencyFile.java 1 70.0%
com/devonfw/tools/ide/property/FileProperty.java 1 80.0%
com/devonfw/tools/ide/property/NumberProperty.java 1 87.5%
com/devonfw/tools/ide/property/ToolProperty.java 2 90.91%
com/devonfw/tools/ide/property/FolderProperty.java 3 0.0%
com/devonfw/tools/ide/property/CommandletProperty.java 3 81.82%
com/devonfw/tools/ide/commandlet/InstallCommandlet.java 3 75.0%
com/devonfw/tools/ide/commandlet/Commandlet.java 4 87.5%
Totals Coverage Status
Change from base Build 10770364106: 0.05%
Covered Lines: 5945
Relevant Lines: 8729

💛 - Coveralls

@slskiba slskiba marked this pull request as ready for review September 2, 2024 07:23
@slskiba slskiba changed the title #438: WIP: validationstate #438: validationstate Sep 3, 2024
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@slskiba thanks for your rework. You created a solid state and are almost there. 👍
I left some comments to guide the way.
Once addressed, we can finally merge.

@hohwille hohwille added this to the release:2024.09.002 milestone Sep 9, 2024
@hohwille hohwille merged commit bd82ae0 into devonfw:main Sep 9, 2024
4 checks passed
@hohwille hohwille added the reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented. label Sep 24, 2024
@hohwille hohwille mentioned this pull request Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented.
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Introduce ValidationState
4 participants