You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ok the Linux/Mac error is a nice one:
If we do Path.of("C:\Windows\system32\drivers\etc\hosts") on Windows, we get the proper absolute path while on Linux or Mac, we get a relative Path with just one segment (file or folder) named C:\Windows\system32\drivers\etc\hosts.
OS abstraction is usually great in Java and you get reproducible behavior on any OS but not work here since the FileSystem implementation is intentionally OS specific. So either we have to ignore such tests if we are not on Windows or we have to build in ugly workarounds/hacks for it...
With the missing change you pushed, output looks good now for env on Windows. However for env --bash, some variables are still not converted correctly:
I added a change to "fix" this but commented it out since it is most probably correct as is and "fixing" it to git-bash syntax might even break maven.
We can test this and if it works with maven (even without IDEasy involved) properly with git-bash syntax, we can comment in the out-commented code to avoid potential confusion.
However, in general on Windows the Windows Paths are typically correct and even required for native processes. Only to make things working in git-bash itself, we need all this messy path conversion stuff.
I also have some doubts that converting M2_REPO to git-bash syntax will be correct and not cause any maven bug.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
enhancementNew feature or requestenvironmentEnvironmentCommandlet, env variables, path, etc.windowsspecific for Microsoft Windows OS
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hohwille
added
enhancement
Fixes #321
EnvironmentCommandletand moved it toWindowsPathSyntaxWindowsPathSyntaxaccording to OS and--bashflagWindowsPathSyntaxtocollectVariablesmethod ofEnvironmentVariablesthat was extended with a variant taking this parameter.getValuemethod that has been extended in the same way.getDefaultValueAsStringmethod ofVariableDefinitionthat has been extended accordingly.VariableDefinitionPathandVariableDefinitionSystemPathnow honor this new parameter to do the actual path conversion.