Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add .editorconfig to settings workspaces #632

Closed
jan-vcapgemini opened this issue Sep 17, 2024 · 0 comments · Fixed by #731
Closed

Add .editorconfig to settings workspaces #632

jan-vcapgemini opened this issue Sep 17, 2024 · 0 comments · Fixed by #731
Assignees
@WorkingAmeise
Labels
enhancement New feature or request intellij IntelliJ IDE from Jet-Brains
Milestone
release:2024.11.001

Comments

@jan-vcapgemini
Copy link
Contributor

jan-vcapgemini commented Sep 17, 2024 •
edited by hohwille
Loading

As an IDEasy user I expect intellij to automatically install an .editorconfig (for our code reformattings) into my workspace.

At the moment we've already added the .editorconfig to our project root in git.
For projects that do not follow such best-practice, we still need the settings to automatically install it to the current workspace.

See #735 for a clean solution of the approach.

See: #465 for reference
@jan-vcapgemini jan-vcapgemini added the enhancement New feature or request label Sep 17, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in IDEasy board Sep 17, 2024
@jan-vcapgemini jan-vcapgemini changed the title Add .editorconfig to settings Add .editorconfig to settings workspaces Sep 17, 2024
@jan-vcapgemini jan-vcapgemini added the intellij IntelliJ IDE from Jet-Brains label Sep 23, 2024
@jan-vcapgemini jan-vcapgemini moved this from 🆕 New to Refinement in IDEasy board Sep 23, 2024
@jan-vcapgemini jan-vcapgemini added this to the release:2024.09.002 milestone Sep 23, 2024
@hohwille hohwille removed this from the release:2024.09.002 milestone Sep 24, 2024
@hohwille hohwille mentioned this issue Oct 25, 2024
Merged
@WorkingAmeise WorkingAmeise mentioned this issue Oct 30, 2024
Merged
@hohwille hohwille added this to the release:2024.11.001 milestone Nov 1, 2024
@hohwille hohwille mentioned this issue Nov 1, 2024
Open
WorkingAmeise added a commit to WorkingAmeise/IDEasy that referenced this issue Nov 11, 2024
@WorkingAmeise
devonfw#632: added tests for IdeToolCommandlet-class
fa57c6e 
Enhanced the intellij test-ressources with workspace.update.editorconfig as well as setup and update folder for the intellij-tool.
Added a Test that checks if the editorconfig file was copied from the settings repo to the workspace after an ide-tool was run.
Added merger for .editorconfig extension which uses the textMerger.
WorkingAmeise added a commit to WorkingAmeise/IDEasy that referenced this issue Nov 11, 2024
@WorkingAmeise
devonfw#632: removed unnneccessary new line
e425488 
Removed new line in DirectoryMerger
hohwille pushed a commit that referenced this issue Nov 11, 2024
@WorkingAmeise
#632: added .editorconfig to settings-workspaces (#731)
1e5e98d
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in IDEasy board Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@WorkingAmeise WorkingAmeise

Labels
enhancement New feature or request intellij IntelliJ IDE from Jet-Brains
Projects
IDEasy board
Status: ✅ Done
Milestone
release:2024.11.001
Development

Successfully merging a pull request may close this issue.

#632: added .editorconfig to settings-workspaces WorkingAmeise/IDEasy
3 participants
@hohwille @jan-vcapgemini @WorkingAmeise