Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final attempt to improve deployment workflows #563

Closed
5 tasks
hohwille opened this issue Aug 26, 2024 · 0 comments · Fixed by #749
Closed
5 tasks

Final attempt to improve deployment workflows #563

hohwille opened this issue Aug 26, 2024 · 0 comments · Fixed by #749
Assignees
Labels
enhancement New feature or request SCM software-configuration-management (github actions, internal processes, git or github utilization)

Comments

@hohwille
Copy link
Member

hohwille commented Aug 26, 2024

While I was stumbling over this topic again with my PR #562 I want to finally get this topic done once and for all.
I thought I had made my goals clear with #427 but this issue was closed while important aspects were never implemented.

  • In the matix OS build all we should do is compile the code and build the native image - no documentation, not test, no packaging/assembly or whatever. That native image should be uploaded via github action upload as executable (not as tar.gz archive) to ${matrix-os}/ideasy[.exe].
  • In the main build we should download the native images via github action download and then trigger the full deployment build. Here the assembly should be build and then be attached as artifact. These assembly can be changed so that they refer the native image directly from the downloaded directory ${matrix-os}/ideasy[.exe] so we do not need additional mapping in the github actions scripts. No need for build-helper-plugin and pointless file-mappings.
  • rename the assembly files to reasonable filenames again as they are not connected to ${matrix.os} anymore. So release-win-x64.xml, release-mac-arm.xml, etc.
  • ensure to update the pom.xml so all assembly descriptors are run during the build. You do not even need to list them all: https://maven.apache.org/plugins/maven-assembly-plugin/single-mojo.html#descriptorSourceDirectory
  • We aggreed that the entire build process gets documented as already described in Improve deployment workflows (nightly and release) #427 but never implemented yet.

This ticket shall not be closed before all tasks are implemented (or moved to other tickets that do not get closed before implemented).
Sorry for saying the obvious but it seemed necessary.

@hohwille hohwille added the enhancement New feature or request label Aug 26, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in IDEasy board Aug 26, 2024
@github-staff github-staff deleted a comment from vineet1401 Oct 23, 2024
@github-staff github-staff deleted a comment from Lxx-c Oct 23, 2024
@github-staff github-staff deleted a comment from Lxx-c Oct 23, 2024
@github-staff github-staff deleted a comment from Lxx-c Oct 23, 2024
@jan-vcapgemini jan-vcapgemini self-assigned this Nov 6, 2024
@jan-vcapgemini jan-vcapgemini moved this from 🆕 New to 🏗 In progress in IDEasy board Nov 6, 2024
jan-vcapgemini added a commit to jan-vcapgemini/IDEasy that referenced this issue Nov 6, 2024
improved nightly build deployment workflow
adjusted upload and download artifact actions
changed native image build phase from package to compile
renamed assembly xml files accordingly
jan-vcapgemini added a commit to jan-vcapgemini/IDEasy that referenced this issue Nov 6, 2024
jan-vcapgemini added a commit to jan-vcapgemini/IDEasy that referenced this issue Nov 6, 2024
made sure that assemblies use matrix os names
removed merge-multiple to extract artifacts into own folders
jan-vcapgemini added a commit to jan-vcapgemini/IDEasy that referenced this issue Nov 6, 2024
added new build profile for assemblies
adjusted assembly xml files
jan-vcapgemini added a commit to jan-vcapgemini/IDEasy that referenced this issue Nov 6, 2024
builds only one image for tests
changed build maven profile to assembly
jan-vcapgemini added a commit to jan-vcapgemini/IDEasy that referenced this issue Nov 6, 2024
set build phase from install to package
made sure that only cli gets built
jan-vcapgemini added a commit to jan-vcapgemini/IDEasy that referenced this issue Nov 6, 2024
jan-vcapgemini added a commit to jan-vcapgemini/IDEasy that referenced this issue Nov 6, 2024
jan-vcapgemini added a commit to jan-vcapgemini/IDEasy that referenced this issue Nov 6, 2024
jan-vcapgemini added a commit to jan-vcapgemini/IDEasy that referenced this issue Nov 6, 2024
jan-vcapgemini added a commit to jan-vcapgemini/IDEasy that referenced this issue Nov 6, 2024
jan-vcapgemini added a commit to jan-vcapgemini/IDEasy that referenced this issue Nov 7, 2024
adjusted workflow steps
changed deploy assembly step to be run on package instead of install
adjusted pom assembly phase
skipped tests in build step
jan-vcapgemini added a commit to jan-vcapgemini/IDEasy that referenced this issue Nov 7, 2024
jan-vcapgemini added a commit to jan-vcapgemini/IDEasy that referenced this issue Nov 7, 2024
jan-vcapgemini added a commit to jan-vcapgemini/IDEasy that referenced this issue Nov 7, 2024
jan-vcapgemini added a commit to jan-vcapgemini/IDEasy that referenced this issue Nov 7, 2024
jan-vcapgemini added a commit to jan-vcapgemini/IDEasy that referenced this issue Nov 11, 2024
jan-vcapgemini added a commit to jan-vcapgemini/IDEasy that referenced this issue Nov 11, 2024
jan-vcapgemini added a commit to jan-vcapgemini/IDEasy that referenced this issue Nov 11, 2024
changed phase of create assemblies to install
added documentation file from ide-doc dependency to artifact
jan-vcapgemini added a commit to jan-vcapgemini/IDEasy that referenced this issue Nov 11, 2024
added assembly profile to deploy
disabled other operating systems for test purposes
jan-vcapgemini added a commit to jan-vcapgemini/IDEasy that referenced this issue Nov 11, 2024
jan-vcapgemini added a commit to jan-vcapgemini/IDEasy that referenced this issue Nov 11, 2024
jan-vcapgemini added a commit to jan-vcapgemini/IDEasy that referenced this issue Nov 11, 2024
jan-vcapgemini added a commit to jan-vcapgemini/IDEasy that referenced this issue Nov 12, 2024
added links to external resources
added examples for id
jan-vcapgemini added a commit to jan-vcapgemini/IDEasy that referenced this issue Nov 14, 2024
re-enabled tests on release deploy step
removed assembly step of nightly build and moved to deploy phase
removed skip of install on nightly build
jan-vcapgemini added a commit to jan-vcapgemini/IDEasy that referenced this issue Nov 19, 2024
adjusted actions-upload link
@hohwille hohwille added this to the release:2024.12.001 milestone Nov 22, 2024
@hohwille hohwille added the SCM software-configuration-management (github actions, internal processes, git or github utilization) label Nov 22, 2024
hohwille pushed a commit that referenced this issue Nov 22, 2024
* #563: Improved deployment workflows
improved nightly build deployment workflow
adjusted upload and download artifact actions
changed native image build phase from package to compile
renamed assembly xml files accordingly

* #563: fixed image names

* #563: adjusted assemblies
made sure that assemblies use matrix os names
removed merge-multiple to extract artifacts into own folders

* #563: adjusted assemblies
added new build profile for assemblies
adjusted assembly xml files

* #563: adjusted assemblies
builds only one image for tests
changed build maven profile to assembly

* #563: adjusted workflow
set build phase from install to package
made sure that only cli gets built

* #563: fixed tar archive name

* #563: skipped tests

* #563: fixed build

* #563: re-enabled other runners

* #563: re-enabled tests

* #563: removed build documentation step
adjusted workflow steps
changed deploy assembly step to be run on package instead of install
adjusted pom assembly phase
skipped tests in build step

* #563: separated build of docs
adjusted comments

* #563: fixed cd

* #563: test

* #563: test

* #563: re-enabled image build

* #563: re-enabled other image builds
removed pwd

* #563: use doc file from dependency
changed phase of create assemblies to install
added documentation file from ide-doc dependency to artifact

* #563: applied changes from nightly-build to release
added assembly profile to deploy
disabled other operating systems for test purposes

* #563: removed upload for test projects

* #563: re-enabled runners

* #563: added documentation file

* #563: implemented requested changes
added links to external resources
added examples for id

* #563: implemented requested changes
re-enabled tests on release deploy step
removed assembly step of nightly build and moved to deploy phase
removed skip of install on nightly build

* #563: implemented requested changes
adjusted actions-upload link
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in IDEasy board Nov 22, 2024
hohwille added a commit that referenced this issue Nov 22, 2024
hohwille added a commit that referenced this issue Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request SCM software-configuration-management (github actions, internal processes, git or github utilization)
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

7 participants
@hohwille @jan-vcapgemini and others