Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate Occasionally failing test #79

Open
MP0w opened this issue Jul 2, 2016 · 4 comments · Fixed by #126
Open

Investigate Occasionally failing test #79

MP0w opened this issue Jul 2, 2016 · 4 comments · Fixed by #126
Assignees
@joanromano @MP0w
Labels
bug

Comments

@MP0w
Copy link
Member

MP0w commented Jul 2, 2016

https://travis-ci.org/devlucky/Kakapo/jobs/141653869

Might not be a timeout (Actually I'm sure it's not a timeout otherwise would be only that test) but another route handler called, either not unregistering one or a race condition
@MP0w MP0w added the bug label Jul 2, 2016
@MP0w MP0w added this to the 0.1.0 milestone Jul 3, 2016
@MP0w
Copy link
Member Author

MP0w commented Jul 3, 2016

might be fixed by f4ebeac

@MP0w
Copy link
Member Author

MP0w commented Jul 6, 2016

@joanromano I already tried to understand but didn't find the cause, happened again (https://travis-ci.org/devlucky/Kakapo/jobs/142811290) so it's not fixed and being always the same test it's not about timeout.
Could be either a bug/race condition in the tests or in the code

@MP0w MP0w removed this from the 0.1.0 milestone Jul 12, 2016
@MP0w
Copy link
Member Author

MP0w commented Jul 12, 2016

After adding some more var for diagnostic: https://travis-ci.org/devlucky/Kakapo/jobs/144227014
This timeout is gonna drive me crazy... it must be a bad bug ... just hope is not a sort of race condition with Quick, maybe I can try to move it to see what happens

@MP0w MP0w added this to the 1.0.0 milestone Aug 20, 2016
@MP0w MP0w removed this from the 1.0.0 milestone Sep 19, 2016
@MP0w MP0w mentioned this issue Sep 22, 2016
Merged
MP0w added a commit that referenced this issue Sep 26, 2016
@MP0w
FIX-ATTEMPT: Try to use a class instead of mutating struct for JSONAP…
f0c586e 
…IError.Builder (#79)

theory some bug while mutating the struct prevent it to work correctly? I don't think it's a Router issue because only happens with this test
@MP0w MP0w mentioned this issue Sep 26, 2016
Merged
@MP0w MP0w closed this as completed in #126 Sep 26, 2016
MP0w added a commit that referenced this issue Sep 26, 2016
@MP0w
FIX-ATTEMPT: Try to use a class instead of mutating struct for JSONAP…
f48cb36 
…IError.Builder (#79) (#126)

theory some bug while mutating the struct prevent it to work correctly? I don't think it's a Router issue because only happens with this test
@MP0w MP0w reopened this Sep 26, 2016
@MP0w
Copy link
Member Author

MP0w commented Sep 26, 2016

still not fixed... trying to increase timeout.
99% sure is not an issue in Router otherwise wouldn't be the only test?
never happened locally...
https://pbs.twimg.com/media/CfSQdwUW8AErog1.jpg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joanromano joanromano

@MP0w MP0w

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

FIX-ATTEMPT: Try to use a class instead of mutating struct for JSONAPIError.Builder devlucky/Kakapo
2 participants
@joanromano @MP0w