Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Let
mock.Invocations.Clear()
remove traces of earlier invocations more thoroughly #854Let
mock.Invocations.Clear()
remove traces of earlier invocations more thoroughly #854Changes from all commits
7a0dd52
92af639
32e021b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This raises the question of whether Moq should generally perform more coarse-grained locking.
This would probably mean having just one lock object on the
Mock
instance that would be used both during setups and invocations.Client code should probably perform all setups first, and only then start invoking the mocked object (possibly from several threads). Code that is structured that way already shouldn't be affected by a move to more coarse-grained locking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had already implemented this, but when I ran some benchmarking it turned out that more coarse-grained locking appears to be slower in general than if each collection kept its own locks.
It also appears that dead-locks currently cannot happen, because we don't have any cyclic call dependencies between
SetupCollection
andInvocationCollection
(IIRC); but that could always change in the future if these collections are modified.For now, let's leave this as a future TODO.