Replace parameter list comparison extension methods #676
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are currently several different ways in the Moq code base for comparing ordered lists of (parameter) types:
Enumerable.SequenceEqual
Enumerable.SequenceEqual
+AssignmentCompatibilityTypeComparer
Extensions.HasSameParameterTypesAs
Extensions.HasCompatibleParameterTypes
Extensions.HasCompatibleParameterList
This refactoring replaces all of the above with three new composable building blocks:
ParameterTypes
— wrapper forParameterInfo[]
so it can be treated likeType[]
Extensions.GetParameterTypes
— gets aMethodInfo
's parameter types as aParameterTypes
Extensions.CompareTo
— compares any pair ofType[]
orParameterTypes
using either of two comparison modes: equality, or assignment-from-compatibility.Care has been taken to keep them fast, and free of any heap allocations.