Extract invocation matching logic into InvocationShape
#662
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactoring moves all logic from
MethodCall
that is related to invocation matching into a dedicated new type,InvocationShape
. This is useful mainly because of two reasons:The invocation matching becomes more easily testable once it is better isolated.
Verification methods such as
mock.Verify(expression)
no longer need to instantiate a transientMethodCall
(which at its heart really represents a setup) in order to match invocations. They will be able to use the much lighter-weightInvocationShape
instead.