Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt assembly versioning scheme 'major.minor.0.0' #554

Merged
merged 1 commit into from
Dec 17, 2017

Conversation

stakx
Copy link
Contributor

@stakx stakx commented Dec 17, 2017

The rationale behind this is that we don't want changes in the patch version to result in a different strong name; patches should be in-place updates and shouldn't lead to version conflicts.

This will help reduce the need for assembly binding redirects.

For now, we only do 'major.minor.0.0' instead of 'major.0.0.0' (which would be even better).

For the next release, we'll have to increase the minor version by 1 to rule out strange-looking binding redirects like these:

4.0.0.0 - 4.7.145.0  ->  4.0.0.0
4.0.0.0 - 4.7.145.0  ->  4.7.0.0

In both cases, the following will probably look less suspicious:

4.0.0.0 - 4.7.145.0  ->  4.8.0.0

Moq 5 will be able to safely make the switch to 'major.0.0.0'.

This closes #424.

The rationale behind this is that we don't want changes in the patch
version to result in a different strong name; patches should be in-
place updates and shouldn't lead to version conflicts.

This will help reduce the need for assembly binding redirects.

For now, we only do 'major.minor.0.0' instead of 'major.0.0.0' (which
would be even better).

For the next release, we'll have to increase the minor version by 1
to rule out strange-looking binding redirects like these:

    4.0.0.0 - 4.7.145.0  ->  4.0.0.0
    4.0.0.0 - 4.7.145.0  ->  4.7.0.0

In both cases, the following will probably look less suspicious:

    4.0.0.0 - 4.7.145.0  ->  4.8.0.0

Moq 5 will be able to safely make the switch to 'major.0.0.0'.
@stakx stakx merged commit a1b01af into devlooped:master Dec 17, 2017
@stakx stakx deleted the assemblyversion branch December 17, 2017 09:55
@devlooped devlooped locked and limited conversation to collaborators Sep 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
1 participant