Ensure incorrect implementations of ISerializable are caught properly #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`SerializableTypesValueProvider` is supposed to work around Castle DynamicProxy refusing to proxy classes that implement ISerializable incorrectly. In such cases, Moq is supposed to just fall back to the empty default value provider, even when a mock has been set up to use the mock default value provider. The problem was mentioned in GitHub issue devlooped#163, and there was even a test demonstrating how Moq previously propagated DynamicProxy's exception. A fix was then added to Moq, but no tests. This commit adds some. Better late than never.
Until now, Moq checked the presence of a deserialization ctor and of a virtual `GetObjectData` method without first checking whether a type actually implements `ISerializable`. These checks happen inside `SerializedTypesValueProvider`, so all related methods are moved there. Also, this value provider is exclu- ded from .NET Core builds, since .NET Core does not have `ISerializ- able` in the first place.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #340.
Moq tries to work around DynamicProxy's refusal to proxy types that implement
ISerializableimproperly. It does so by defaulting toEmptyDefaultValueProviderfor such types (which will never try to mock them, but simply returnsnullinstead).Moq's logic to detect bad
ISerializableimplementations however is currently faulty itself: It checks for the presence of a deserialization constructor and/or a virtualGetObjectDatamethod without first checking whether the type in question implementsISerializable.This issue gets fixed here. All necessary logic is moved to
SerializableTypesValueProviderwhere it belongs. Additionally, tests are added that document why that class was added to Moq in the first place.