Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coreinit/screen: Swap row and column parameters in OSScreenPutFontEx #391

Merged
merged 2 commits into from
Jul 19, 2024

Conversation

capitalistspz
Copy link
Contributor

They were wrong

@capitalistspz capitalistspz changed the title coreinit/OSScreenPutFontEx: Swap row and column parameters coreinit/screen: Swap row and column parameters in OSScreenPutFontEx Jul 17, 2024
@GaryOderNichts
Copy link
Contributor

GaryOderNichts commented Jul 19, 2024

The row and column part seems fine to me as is. The only thing that's currently wrong is the 0 corresponds to [..] part of the comments.

@capitalistspz
Copy link
Contributor Author

If we consider spreadsheets, for example, the row is the number of lines down, and the column is the number of lines across
image
image

@GaryOderNichts
Copy link
Contributor

Eh yeah of course, you're right.
I was thinking about how a row runs along the x-axis and a column along the y-axis.

@GaryOderNichts GaryOderNichts merged commit 7044eaa into devkitPro:master Jul 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants