Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More DRX definitions #385

Merged
merged 2 commits into from
Jun 18, 2024
Merged

More DRX definitions #385

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
647de79
More DRX definitions
team-orangeBlue Jun 13, 2024
9e59558
Unneeded comment removed
team-orangeBlue Jun 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions include/nsysccr/cdc.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,13 +136,14 @@ typedef enum CCRCDCExt

typedef enum CCRCDCDrhStateEnum
{
CCR_CDC_SYS_DRH_STATE_UNK0 = 0x00,
CCR_CDC_SYS_DRH_STATE_UNK1 = 0x01,
CCR_CDC_SYS_DRH_STATE_UNK2 = 0x02,
CCR_CDC_SYS_DRH_STATE_UNK3 = 0x03,
CCR_CDC_SYS_DRH_STATE_ECO = 0x04,
CCR_CDC_SYS_DRH_STATE_UNK7F = 0x7F,
CCR_CDC_SYS_DRH_STATE_CAFE = 0xFF,
CCR_CDC_SYS_DRH_STATE_NORADIO = 0x00,
CCR_CDC_SYS_DRH_STATE_WII = 0x01,
CCR_CDC_SYS_DRH_STATE_UNK2 = 0x02,
CCR_CDC_SYS_DRH_STATE_NODRC = 0x03,
CCR_CDC_SYS_DRH_STATE_ECO = 0x04,
//! On latest firmware this state is not recognized
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This state is definitely recognized on the latest firmware, even if it fails to enter it.
There are several references to it in the set and get state code.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The suggestion is for state 7F, not state 04.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I'm talking about state 7F, I just put the comment one line too high.

CCR_CDC_SYS_DRH_STATE_UNK7F = 0x7F,
CCR_CDC_SYS_DRH_STATE_CAFE = 0xFF,
} CCRCDCDrhStateEnum;

struct WUT_PACKED CCRCDCMacAddress
Expand Down Expand Up @@ -185,9 +186,10 @@ WUT_CHECK_SIZE(CCRCDCSysMessage, 0x4);
struct WUT_PACKED CCRCDCEepromData
{
uint32_t version;
WUT_UNKNOWN_BYTES(0x300);
uint8_t data[0x300];
};
WUT_CHECK_OFFSET(CCRCDCEepromData, 0x0, version);
WUT_CHECK_OFFSET(CCRCDCEepromData, 0x4, data);
WUT_CHECK_SIZE(CCRCDCEepromData, 0x304);

struct WUT_PACKED CCRCDCWowlWakeDrcArg
Expand Down