Implement more functions/classes from nn::sl #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maschell
force-pushed
the
nn_sl_2
branch
2 times, most recently
from
80bc51d
to
316ceea
Compare
|
|
||
| #ifdef __cplusplus | ||
|
|
||
| namespace nn::sl { |
There was a problem hiding this comment.
Nested namespaces are only available since C++17. As long as there isn't anything else which requires a newer C++ standard, it probably makes sense to avoid this.
There was a problem hiding this comment.
gcc doesn't give me a warning/error when using -std=c++11 and -Wall so it might be fine to use it anyway?
…Stream interface properly, rename anonymus namespaces to "details"
…ionTransferRecordPath
…tabase::Unregister
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.