ogc: always let application decide on mouse visibility #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our heuristics break the "Abbaye des Morts" game, which does not need a mouse cursor and just calls `SDL_ShowCursor(SDL_DISABLE)` at startup. Yet, with the current version of SDL, if the wiimote is pointed at the screen we are still showing a cursor, overriding the application's explicit decision. And the mouse cursor is useless, since the application is not reacting to a mouse. The code we are removing was mainly added with the intent of _hiding_ the mouse cursor when the wiimote was not pointed at the screen, and we could indeed update it and keep it working just as an additional check on whether the cursor should be shown or not, but we don't really have a concrete use-case here. Let's just remove it completely for now, and bring it back (still respecting an explicit SDL_DISABLE setting, though!) if/when we see a reason to.
WinterMute
pushed a commit
that referenced
this pull request
Oct 27, 2024
Our heuristics break the "Abbaye des Morts" game, which does not need a mouse cursor and just calls `SDL_ShowCursor(SDL_DISABLE)` at startup. Yet, with the current version of SDL, if the wiimote is pointed at the screen we are still showing a cursor, overriding the application's explicit decision. And the mouse cursor is useless, since the application is not reacting to a mouse. The code we are removing was mainly added with the intent of _hiding_ the mouse cursor when the wiimote was not pointed at the screen, and we could indeed update it and keep it working just as an additional check on whether the cursor should be shown or not, but we don't really have a concrete use-case here. Let's just remove it completely for now, and bring it back (still respecting an explicit SDL_DISABLE setting, though!) if/when we see a reason to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our heuristics break the "Abbaye des Morts" game, which does not need a mouse cursor and just calls
SDL_ShowCursor(SDL_DISABLE)at startup. Yet, with the current version of SDL, if the wiimote is pointed at the screen we are still showing a cursor, overriding the application's explicit decision. And the mouse cursor is useless, since the application is not reacting to a mouse.The code we are removing was mainly added with the intent of hiding the mouse cursor when the wiimote was not pointed at the screen, and we could indeed update it and keep it working just as an additional check on whether the cursor should be shown or not, but we don't really have a concrete use-case here.
Let's just remove it completely for now, and bring it back (still respecting an explicit SDL_DISABLE setting, though!) if/when we see a reason to.