Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move time block notebook to seismic/tutorials #1441

Merged
merged 4 commits into from
Sep 2, 2020
Merged

Conversation

jkwashbourne
Copy link
Collaborator

Per discussion on slack. I also updated examples/README.md

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

Review Jupyter notebook visual diffs & provide feedback on notebooks.


Powered by ReviewNB

@jkwashbourne jkwashbourne added the examples examples label Aug 28, 2020
@codecov
Copy link

codecov bot commented Aug 28, 2020

Codecov Report

Merging #1441 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1441      +/-   ##
==========================================
- Coverage   87.01%   87.00%   -0.01%     
==========================================
  Files         188      188              
  Lines       27072    27072              
  Branches     3674     3674              
==========================================
- Hits        23557    23555       -2     
- Misses       3089     3090       +1     
- Partials      426      427       +1     
Impacted Files Coverage Δ
devito/compiler.py 54.72% <0.00%> (-0.68%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 323bce6...7b9cad1. Read the comment docs.

Copy link
Contributor

@FabioLuporini FabioLuporini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uncontroversial

@mloubout mloubout merged commit 6050f51 into master Sep 2, 2020
@mloubout mloubout deleted the move_timeblock_nb branch September 2, 2020 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants