Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: weblate (original, plain, original-wordmark, plain-wordmark) #544

Merged
merged 9 commits into from
Apr 1, 2021
Merged

Conversation

maltejur
Copy link
Contributor

@maltejur maltejur commented Mar 30, 2021

Add icon for weblate (localization platform)

Screenshot 2021-04-01 190416

@github-actions
Copy link
Contributor

Hi!

I'm Devicons' SVG-Checker Bot and it seems we have some issues with your SVGs.

Here is what went wrong:

icons/weblate/weblate-plain.svg:
-unneccessary 'x' attribute in svg element -> Remove it
-unneccessary 'y' attribute in svg element -> Remove it
-contains style declaration using 'fill' -> Replace classes with the 'fill' attribute instead

For more reference on why these are errors, check out our CONTRIBUTING guide

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

PS. One day, I will be smart enough to fix these errors for you 😣. Until then, I can only point them out.

@github-actions

This comment has been minimized.

@Panquesito7 Panquesito7 added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Mar 30, 2021
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's also an icon with the name of the technology (in this case it's Weblate; wordmark version).
Weblate Wordmark

icons/weblate/weblate-original.svg Outdated Show resolved Hide resolved
icons/weblate/weblate-plain.svg Outdated Show resolved Hide resolved
@Panquesito7 Panquesito7 changed the title add icon: weblate (original, plain) new icon: weblate (original, plain) Mar 30, 2021
@github-actions

This comment has been minimized.

2 similar comments
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@maltejur maltejur changed the title new icon: weblate (original, plain) new icon: weblate (original, plain, original-wordmark, plain-wordmark) Apr 1, 2021
@github-actions

This comment has been minimized.

Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should probably consider making the text white for the wordmark versions (see the Weblate website).

icons/weblate/weblate-original-wordmark.svg Outdated Show resolved Hide resolved
icons/weblate/weblate-plain-wordmark.svg Outdated Show resolved Hide resolved
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2021

Hi!
I'm Devicons' SVG-Checker Bot and everything looks great. Good job!

Have a nice day,
SVG-Checker Bot 😁

@Panquesito7
Copy link
Member

You should probably consider making the text white for the wordmark versions (see the Weblate website).

@maltejur
Copy link
Contributor Author

maltejur commented Apr 1, 2021

That is just because the website has a dark background, isn't it? I think it is probably more useful if the text is black for the icon.

@amacado amacado added the bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger label Apr 1, 2021
@Panquesito7
Copy link
Member

Panquesito7 commented Apr 1, 2021

@amacado @Thomas-Boi, there seem to be problems with the Peek Icons workflow. Maybe due to the latest changes in the workflow? 🤔 Never mind, it seems the workflow wasn't able to connect to the Icomoon website. 🤷‍♂️

@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2021

Hi!
I'm Devicons' SVG-Checker Bot and everything looks great. Good job!

Have a nice day,
SVG-Checker Bot 😁

@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2021

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.
Here is the result below:

Imgur Images

Here are the zoomed-in screenshots of the added icons:
Imgur ImagesImgur Images

Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice.

The maintainers will now take a look at it and decide whether to merge your PR.

Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo.

Cheers,
Peek Bot 😊

@amacado
Copy link
Member

amacado commented Apr 1, 2021

@amacado @Thomas-Boi, there seem to be problems with the Peek Icons workflow. Maybe due to the latest changes in the workflow? 🤔 Never mind, it seems the workflow wasn't able to connect to the Icomoon website. 🤷‍♂️

Yep. That's a well known bug.

Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for your contribution. Weblate will be included in the next release! 👍 🎉

Copy link
Member

@amacado amacado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me the icons looking fine! Thanks for adding them @maltejur

@Panquesito7 Panquesito7 merged commit cc52210 into devicons:develop Apr 1, 2021
@maltejur
Copy link
Contributor Author

maltejur commented Apr 1, 2021

@amacado would it be possible to create a new release now? I need two new icons that aren't on npm yet.

@Thomas-Boi
Copy link
Member

@amacado would it be possible to create a new release now? I need two new icons that aren't on npm yet.

Hey @maltejur, I think we will wait for a couple more days. If there are no more icons then, we'll probably make a new release. I hope that you can wait until then :)

@amacado amacado mentioned this pull request Apr 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants