-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new icon: weblate (original, plain, original-wordmark, plain-wordmark) #544
Conversation
Hi! I'm Devicons' SVG-Checker Bot and it seems we have some issues with your SVGs. Here is what went wrong:
For more reference on why these are errors, check out our CONTRIBUTING guide Please address these issues. When you update this PR, I will check your SVGs again. Thanks for your help, PS. One day, I will be smart enough to fix these errors for you 😣. Until then, I can only point them out. |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: David Leal <[email protected]>
Co-authored-by: David Leal <[email protected]>
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should probably consider making the text white for the wordmark versions (see the Weblate website).
This comment has been minimized.
This comment has been minimized.
Co-authored-by: David Leal <[email protected]>
This comment has been minimized.
This comment has been minimized.
Hi! Have a nice day, |
|
That is just because the website has a dark background, isn't it? I think it is probably more useful if the text is black for the icon. |
|
Hi! Have a nice day, |
Hi there, I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here are the zoomed-in screenshots of the added icons: Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice. The maintainers will now take a look at it and decide whether to merge your PR. Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo. Cheers, |
Yep. That's a well known bug. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you for your contribution. Weblate will be included in the next release! 👍 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me the icons looking fine! Thanks for adding them @maltejur
@amacado would it be possible to create a new release now? I need two new icons that aren't on npm yet. |
Add icon for weblate (localization platform)