Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New icon: arduino (original, original-wordmark, plain, plain-wordmark) #532

Merged
merged 24 commits into from
Apr 27, 2021
Merged

New icon: arduino (original, original-wordmark, plain, plain-wordmark) #532

merged 24 commits into from
Apr 27, 2021

Conversation

EnisMulic
Copy link
Contributor

No description provided.

@github-actions

This comment has been minimized.

Sign in to view
@Panquesito7 Panquesito7 added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Mar 17, 2021
Panquesito7
Panquesito7 requested changes Mar 17, 2021
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the Wikipedia page for Arduino, the logo has the TM text on the corner right, but in your icon, it says R. I guess it should be TM.

devicon.json Outdated Show resolved Hide resolved
icons/arduino/arduino-original.svg Outdated
</defs>
<g id="surface1">
<g clip-path="url(#clip1)" clip-rule="nonzero">
<path fill="#00979d" style="fill-rule:evenodd;" d="M 127.867188 31.210938 C 127.867188 13.988281 113.714844 0 96.367188 0 C 94.769531 0 93.128906 0.0898438 91.53125 0.363281 C 78.042969 2.324219 68.992188 12.300781 63.933594 19.957031 C 58.875 12.300781 49.824219 2.324219 36.339844 0.363281 C 34.742188 0.136719 33.097656 0 31.5 0 C 14.109375 0 0 13.988281 0 31.210938 C 0 48.433594 14.152344 62.421875 31.5 62.421875 C 33.097656 62.421875 34.742188 62.332031 36.382812 62.058594 C 49.867188 60.054688 58.921875 50.074219 63.980469 42.421875 C 69.039062 50.074219 78.089844 60.054688 91.574219 62.058594 C 93.171875 62.285156 94.8125 62.421875 96.457031 62.421875 C 113.714844 62.421875 127.867188 48.433594 127.867188 31.210938 Z M 34.785156 51.125 C 33.675781 51.304688 32.566406 51.351562 31.457031 51.351562 C 20.011719 51.351562 10.738281 42.285156 10.738281 31.210938 C 10.738281 20.09375 20.054688 11.070312 31.5 11.070312 C 32.609375 11.070312 33.71875 11.164062 34.828125 11.300781 C 47.5625 13.167969 55.324219 26.0625 57.988281 31.210938 C 55.28125 36.40625 47.472656 49.253906 34.785156 51.125 Z M 93.039062 11.300781 C 80.304688 13.167969 72.496094 26.0625 69.878906 31.210938 C 72.496094 36.359375 80.304688 49.253906 93.039062 51.125 C 94.148438 51.261719 95.257812 51.351562 96.367188 51.351562 C 107.769531 51.351562 117.085938 42.328125 117.085938 31.210938 C 117.085938 20.140625 107.816406 11.070312 96.367188 11.070312 C 95.257812 11.070312 94.148438 11.164062 93.039062 11.300781 Z M 22.613281 27.867188 L 41.667969 27.867188 L 41.667969 33.871094 L 22.613281 33.871094 Z M 105.160156 33.914062 L 98.734375 33.914062 L 98.734375 40.21875 L 92.578125 40.21875 L 92.578125 33.914062 L 86.152344 33.914062 L 86.152344 27.867188 L 92.578125 27.867188 L 92.578125 21.5625 L 98.734375 21.5625 L 98.734375 27.867188 L 105.160156 27.867188 Z M 119.761719 3.460938 C 119.761719 1.570312 121.300781 0 123.175781 0 C 125.101562 0 126.648438 1.570312 126.648438 3.460938 C 126.648438 5.460938 125.101562 6.921875 123.175781 6.921875 C 121.300781 6.921875 119.761719 5.355469 119.761719 3.460938 Z M 123.222656 1.296875 L 121.515625 1.296875 L 121.515625 5.625 L 122.617188 5.625 L 122.617188 4.164062 L 123.222656 4.164062 L 123.832031 5.625 L 125.042969 5.625 L 124.214844 4 C 124.765625 3.785156 125.042969 3.351562 125.042969 2.757812 C 125.042969 1.839844 124.546875 1.296875 123.222656 1.296875 Z M 126.035156 3.460938 C 126.035156 1.890625 124.824219 0.539062 123.171875 0.539062 C 121.519531 0.539062 120.363281 1.730469 120.363281 3.460938 C 120.363281 5.246094 121.683594 6.382812 123.171875 6.382812 C 124.824219 6.382812 126.035156 5.246094 126.035156 3.460938 Z M 123.886719 2.703125 C 123.886719 3.246094 123.609375 3.40625 123.113281 3.40625 L 122.5625 3.460938 L 122.5625 2.054688 L 123.113281 2.054688 C 123.71875 2.054688 123.886719 2.21875 123.886719 2.703125 Z M 123.886719 2.703125 "/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the white/blank space here (same with the plain version).
image

devicon.json Outdated Show resolved Hide resolved
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@EnisMulic EnisMulic marked this pull request as draft March 18, 2021 08:34
@github-actions

This comment has been minimized.

Sign in to view
@maltejur
Copy link
Contributor

maltejur commented Mar 23, 2021 •
edited
Loading

The icons should probably be centered

@github-actions

This comment has been minimized.

Sign in to view
@Panquesito7
Copy link
Member

@EnisMulic, is this PR ready for review now? I think you marked it as "Draft" accidentally. Thank you anyways. 🙂

@github-actions

This comment has been minimized.

Sign in to view
@EnisMulic
Copy link
Contributor Author

@Panquesito7 Sorry, I still haven't aligned the icons

@github-actions

This comment has been minimized.

Sign in to view
@Panquesito7 Panquesito7 marked this pull request as ready for review April 9, 2021 22:56
@github-actions

This comment has been minimized.

Sign in to view
2 similar comments
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
1 similar comment
@github-actions

This comment has been minimized.

Sign in to view
@Panquesito7 Panquesito7 added the bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger label Apr 10, 2021
@github-actions

This comment has been minimized.

Sign in to view
1 similar comment
@github-actions
Copy link
Contributor

Hi!
I'm Devicons' SVG-Checker Bot and everything looks great. Good job!

Have a nice day,
SVG-Checker Bot 😁

@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.
Here is the result below:

Imgur Images

Here are the zoomed-in screenshots of the added icons:
Imgur ImagesImgur Images

Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice.

The maintainers will now take a look at it and decide whether to merge your PR.

Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo.

Cheers,
Peek Bot 😊

@amacado amacado mentioned this pull request Apr 10, 2021
Merged
@Thomas-Boi
Copy link
Member

Update: I've emailed Icomoon regarding the issue seen here.

I've also take a look at the created SVG and compared them. One of the path element changed and I do not know what's causing it. The original SVG uses fill, not stroke, so I couldn't find the error. We'll wait and see what Icomoon says about this.

@Thomas-Boi
Copy link
Member

Hi all,

The Icomoon team has quickly responded. Here is their response:

Hi,

This issue seems to be caused by a bug in the SVG path parser in the current version of IcoMoon app. The new version which we have been working on for a couple of years now doesn’t have this issue.

The new version of IcoMoon app won’t be ready anytime soon. In the meanwhile, you can use the attached SVG instead of your own. It’s basically the same SVG with separate paths.

Best Regards,
IcoMoon team

I have the updated svg and I will commit it to this PR soon. Until then, there is nothing we can do about this.

@Thomas-Boi Thomas-Boi added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Apr 27, 2021
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and it seems we've ran into a problem (sorry!).

Please double check and fix the possible issues below:

  • Your svgs are named and added correctly to the /icons folder as seen here.
  • Your icon information has been added to the devicon.json as seen here
  • Your PR title follows the format seen here

I will retry once everything is fixed. If I still fail (sorry!) or there are other erros, the maintainers will investigate.

Best of luck,
Peek Bot ☺️

@Thomas-Boi Thomas-Boi added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Apr 27, 2021
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.
Here is the result below (top right):

Imgur Images

Here are the zoomed-in screenshots of the added icons:
Imgur ImagesImgur Images

Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice.

The maintainers will now take a look at it and decide whether to merge your PR.

Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo.

Cheers,
Peek Bot 😊

@Thomas-Boi @Panquesito7
Update devicon.json
a9bc39b 
Co-authored-by: David Leal <[email protected]>
@Thomas-Boi
Copy link
Member

Alright, everything looks good! I'll merge the PR now

@Thomas-Boi Thomas-Boi dismissed Panquesito7’s stale review April 27, 2021 00:42

The files have been updated as requested

Thomas-Boi
Thomas-Boi approved these changes Apr 27, 2021
View reviewed changes
Copy link
Member

@Thomas-Boi Thomas-Boi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the files are minified and are built properly. This can be merged.

@Thomas-Boi Thomas-Boi merged commit be0f017 into devicons:develop Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thomas-Boi Thomas-Boi Thomas-Boi approved these changes

@Panquesito7 Panquesito7 Panquesito7 left review comments

Assignees
No one assigned
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@EnisMulic @maltejur @Panquesito7 @Thomas-Boi @Kartstig