Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New icon: after effects (plain, original) #336

Merged
merged 4 commits into from
Oct 31, 2020
Merged

New icon: after effects (plain, original) #336

merged 4 commits into from
Oct 31, 2020

Conversation

ezSaldana
Copy link
Contributor

@ezSaldana ezSaldana commented Oct 24, 2020 •
edited
Loading

Added After Effects icon

I've added the plain and original After Effects icons. Give it a check and let me know if there's something I should change.

Image

afterEffects-icons-example

Issue Reference

#110

@amacado
Copy link
Member

amacado commented Oct 25, 2020

Thanks for the afford, but I'm not sure if after affects matches this projects description of "developer icons" (see README.md)

Devicon aims to gather all logos representing development languages and tools

@Thomas-Boi, @konpa what do you think? Open discussion.

@amacado amacado added discussion Use this label for community discussions about changes/features/.. feature:icon Use this label for pull requests when a new icon is ready to be added to the collection labels Oct 25, 2020
@Thomas-Boi
Copy link
Member

I think that we can accept the After Effects icons. I searched up the app and some people use it for video game development (which is a programming job). We also have Adobe Photoshop in our repo so I think we can accept Adobe apps (as long as it's used for tech jobs)

@amacado amacado self-requested a review October 30, 2020 16:42
amacado
amacado requested changes Oct 30, 2020
View reviewed changes
Copy link
Member

@amacado amacado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as in #337: Please lowercase all filenames to match our conventions :)

@amacado amacado removed the discussion Use this label for community discussions about changes/features/.. label Oct 30, 2020
@amacado amacado self-requested a review October 31, 2020 01:03
@amacado amacado added the bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger label Oct 31, 2020
amacado
amacado approved these changes Oct 31, 2020
View reviewed changes
Copy link
Member

@amacado amacado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me! :) Thanks for the contribution @ezSaldana

image

@amacado amacado merged commit 10c9c81 into devicons:develop Oct 31, 2020
@ezSaldana
Copy link
Contributor Author

Not at all!

@ezSaldana ezSaldana deleted the afterEffects branch October 31, 2020 04:27
@Snailedlt Snailedlt mentioned this pull request Nov 7, 2022
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amacado amacado amacado approved these changes

Assignees

@ezSaldana ezSaldana

Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ezSaldana @amacado @Thomas-Boi