-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new icon: embeddedc (original, plain, original-wordmark, plain-wordmark) #284
Conversation
Hello @mjlabe thanks for this contribution as well! :) Can you provide us with a resource for this icon? I was not able to find any "official" design for embedded c. Is this your own creation? |
Yes. I took the C icon and added an embedded chip in the background. There's no "official" icon just like C, but should we add tags like this: |
Hi, can someone add the Jenkins icon please? https://iconscout.com/icon/jenkins-2 |
To request a new icon, please create a new issue. You can submit an icon by following the the guidelines here: https://github.com/devicons/devicon/blob/master/CONTRIBUTING.md |
Hello there,
Thank you for contributing to this repo. We are sorry that we haven't accept any PR for awhile. Now that we have a build pipeline, we can merge PRs more quickly than before. We hope to see your icons in the Devicon repo soon :) Cheers, |
Hi @mjlabe, I'm working on merging your PR to accept your icon. However, it seems like your branch is a bit out of date. It'd be much appreciated if you can bring the branch up to date with develop and re-push. After a week, if the branch hasn't been updated I'll make a new PR cherry-picking your commit. This is to ensure you are still the author of the commit and get proper credits. You can also just give me permission to do it this way now. It'd be quicker if you update the branch yourself though but whichever works 👍 |
This PR is now remade. You can view it in #625. Thank you for your work 👍. Also, I could not find an official logo for embedded-c. However, the one that you have look professional enough so we'll accept it. If someone let us know this is not the official logo, we will have to remove it. |
Embedded C icon from PR #136