update icon: bash: Remove invisible outline of plain icon #2263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[why] When calculating the bounding box of the icon the real icon is too far right. There is in fact a invisible box on the real icon's left. [how] Edit `svg` file directly (in vi) and just remove the outline's description. Signed-off-by: Fini Jastrow <[email protected]>
Finii
changed the title
Snailedlt
requested review from
a team,
ConX,
weh,
Snailedlt,
canaleal and
lunatic-fox
and removed request for
a team
Snailedlt
added
the
feature:icon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[why]
When calculating the bounding box of the icon the real icon is too far right. There is in fact a invisible box on the real icon's left.
[how]
Edit
svgfile directly (in vi) and just remove the outline's description.Double check these details before you open a PR
Features
Load icon into
inkscapeand just select all - note the ghost square on the left ?!Removed path marked blue:
This PR closes NONE
Notes
@Snailedlt as per ryanoasis/nerd-fonts#1691 (comment)