-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update icon: cosmosdb (original, original-wordmark) #2140
base: develop
Are you sure you want to change the base?
Conversation
Hi! I'm the
Check our CONTRIBUTING guide for more details regarding these errors. Please address these issues. When you update this PR, I will check your SVGs again. Thanks for your help, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall excellent 👍
2 changes needed:
- (OPTIONAL) Ungroup the paths in the
original.svg
- There's some bottom padding in the
original-wordmark.svg
Hi! I'm the
Check our CONTRIBUTING guide for more details regarding these errors. Please address these issues. When you update this PR, I will check your SVGs again. Thanks for your help, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work on original.svg
👍
However, there's another issue with original-wordmark.svg
. While the padding problem has been resolved, the SVG has been enlarged and is not properly centered.
If using inkscape the following steps will help solve the issue:
- Select all paths and group them
- Press the lock icon in the top right
- Set the height to 128 in the input box
- Center the SVG horizontally and vertically using the options in the
align and distribute
menu
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just found out, that this happened while resizing with https://www.iloveimg.com/resize-image
i will check later what is wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think i finally fixed this now. Can you please review it again @canaleal :)
c3508ae
to
6a24b87
Compare
Hi! I'm the
Check our CONTRIBUTING guide for more details regarding these errors. Please address these issues. When you update this PR, I will check your SVGs again. Thanks for your help, |
Double check these details before you open a PR
Features
This PR closes #2134
Notes