-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new icon: filamentphp (original) #2122
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, here are few changes that are needed:
- Instead of
plain-wordmark
call the SVGoriginal
as the icon you added is the original filamentphp logo. - Optimize and clean up the SVG like we did in the remix pr. Because the SVG only has 1 color, you can combine the paths into 1 path; This reduces the size of the svg and makes it possible for us the svg as an base/ alias for other version.
- Because there is only 1 path and fill color you can use the
filamentphp-original.svg
as the base and make aliases fororiginal-wordmark
,plain
, andplain-wordmark
.
using InkScape, SVGOMG, SVGviewer
These changes are done!! |
Made some changes in "aliases": [
{
"base": "original",
"alias": [
"original-wordmark",
"plain",
"plain-wordmark"
]
}
] Kindly. verify it @canaleal |
By the way, the SVG has a |
Removed: fill="currentColor", class="transition duration-300 will-change-transform group-hover/filament:-translate-x-[1.2rem] motion-reduce:transition-none"
Done, anymore changes required? |
Hi! I'm the
Check our CONTRIBUTING guide for more details regarding these errors. Please address these issues. When you update this PR, I will check your SVGs again. Thanks for your help, |
Hi! I'm the
Check our CONTRIBUTING guide for more details regarding these errors. Please address these issues. When you update this PR, I will check your SVGs again. Thanks for your help, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great use of aliases! 💯
Thank you for your contribution! 🙇♂️
Hi! I'm the
Check our CONTRIBUTING guide for more details regarding these errors. Please address these issues. When you update this PR, I will check your SVGs again. Thanks for your help, |
Double check these details before you open a PR
This PR closes #2120
Link to prove your SVG is correct and up-to-date.
https://filamentphp.com/