-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update icon: kubernetes (original, original-wordmark, plain, plain-wordmark, line, line-wordmark) #2066
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one image looks like it is not centered (vertical)
The rest is good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like @weh already mentioned the wordmark versions appear to not be vertically centered
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Top 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Double check these details before you open a PR
develop
branch.devicon.json
file as seen hereThis PR is related to #1998
Link to prove your SVG is correct and up-to-date.
Additional Notes
The ship wheel was clipped out from the plain and line SVGs. I did this because the ship wheel is ontop the blue heptagon as a white path.
The blue color
#326ce5
was used for the font SVGs.