Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update icon: kubernetes (original, original-wordmark, plain, plain-wordmark, line, line-wordmark) #2066

Merged
merged 4 commits into from
Dec 17, 2023

Conversation

canaleal
Copy link
Member

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR is related to #1998

Link to prove your SVG is correct and up-to-date.

Additional Notes

The ship wheel was clipped out from the plain and line SVGs. I did this because the ship wheel is ontop the blue heptagon as a white path.

The blue color #326ce5 was used for the font SVGs.

@canaleal canaleal added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Nov 27, 2023
lunatic-fox
lunatic-fox previously approved these changes Nov 30, 2023
Copy link
Contributor

@lunatic-fox lunatic-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks fine! 👍🏼
Thank you for this contribution! 🚀
image
image
image
image

@lunatic-fox lunatic-fox requested review from Snailedlt, a team, ConX and weh and removed request for a team November 30, 2023 04:17
Copy link
Contributor

@weh weh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one image looks like it is not centered (vertical)
The rest is good.

Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like @weh already mentioned the wordmark versions appear to not be vertically centered

Copy link
Contributor

@weh weh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Top 👍

@weh weh requested a review from Snailedlt December 5, 2023 22:51
Copy link
Contributor

@lunatic-fox lunatic-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 It appears to not be vertically centered, however if you zoom in you can see that it's properly centered. Here's an example:
image
image

@Snailedlt Snailedlt merged commit 2317055 into devicons:develop Dec 17, 2023
5 checks passed
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants