Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix/fix: references of faunadb and ceylon #2040

Merged
merged 1 commit into from
Nov 24, 2023

Conversation

lunatic-fox
Copy link
Contributor

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened

Features

This PR partially closes #1998

Notes

@weh weh requested review from a team, ConX, Snailedlt and canaleal and removed request for a team November 24, 2023 12:59
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a 100% sure this will work for the build workflow, but let's merge it and see if it does ;)

If it doesn't we'll just have to create a separate PR for each icon

@Snailedlt Snailedlt merged commit 00867dc into devicons:develop Nov 24, 2023
5 checks passed
@lunatic-fox
Copy link
Contributor Author

I'm not a 100% sure this will work for the build workflow, but let's merge it and see if it does ;)

If it doesn't we'll just have to create a separate PR for each icon

I think it will at least for faunadb as far as we have #1265 pull request and hope it works for ceylon since I didn't see any PR for this icon, probably because it's a old one.

@Snailedlt
Copy link
Collaborator

@lunatic-fox ahh, if that's the case then I'm pretty sure it won't work. Since it uses the PR title to know which icons it should add to the font and devicon.css. That's why the build failed last time when we changed the name of an icon, because it was looking at an old PR with the name 3dsmax, but in the repo the 3dsmax icons didn't exist... only threedsmax.
This is unfortunate... but I don't think we need to fix it since we'll have to change to a different way of building anyways once we move to trunk based development in #1933

@lunatic-fox
Copy link
Contributor Author

lunatic-fox commented Nov 24, 2023

@lunatic-fox ahh, if that's the case then I'm pretty sure it won't work. Since it uses the PR title to know which icons it should add to the font and devicon.css. That's why the build failed last time when we changed the name of an icon, because it was looking at an old PR with the name 3dsmax, but in the repo the 3dsmax icons didn't exist... only threedsmax.
This is unfortunate... but I don't think we need to fix it since we'll have to change to a different way of building anyways once we move to trunk based development in #1933

Hmm... so, can you please revert this PR? I'll split it when I'm back home at night.

Snailedlt added a commit that referenced this pull request Nov 24, 2023
Snailedlt added a commit that referenced this pull request Nov 24, 2023
@Snailedlt
Copy link
Collaborator

reverted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants