-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update icon: lua (original, original-wordmark, plain, plain-wordmark, line, line-wordmark) #2033
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
i only asked myself, if the "non-wordmark" versions really are official, or needed. but since the plain ones already existed, i think its ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As @weh commented and as far as I see there are no "non-wordmark" versions for this icon.
- The
original
version has "Lua" in#ffffff
.
original
Perhaps, we should make these changes:
- Rename
original-wordmark
tooriginal
, deleteoriginal-wordmark
. Aliasoriginal
asoriginal-wordmark
. - Rename
plain-wordmark
toplain
, deleteplain-wordmark
. Aliasplain
asplain-wordmark
. - Rename
line-wordmark
toline
, deleteline-wordmark
. Aliasline
asline-wordmark
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Double check these details before you open a PR
develop
branch.devicon.json
file as seen hereThis PR is related to #1998
Link to prove your SVG is correct and up-to-date.
Additional Notes
Used the color
#000080
for the font SVGs.All 3 versions were created as the Original SVGs had 2 colors; Navy for the planet/moon and gray for the orbit path.