Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: processwire (original, original-wordmark, plain-wordmark) #1905

Merged
merged 9 commits into from
Nov 17, 2024

Conversation

SkyLundy
Copy link

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes NONE

Link to prove your SVG is correct and up-to-date.

https://processwire.com

Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to the suggested changed processwire-original-wordmark.svg also needs to be cleaned up a little. I suggest you try to do this yourself, but if you get stuck don't hesitate to ask for help :)

devicon.json Show resolved Hide resolved
icons/processwire/processwire-plain-wordmark.svg Outdated Show resolved Hide resolved
icons/processwire/processwire-original.svg Outdated Show resolved Hide resolved
devicon.json Outdated Show resolved Hide resolved
@Snailedlt Snailedlt added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Oct 30, 2023
@Snailedlt Snailedlt changed the title new icon: ProcessWire (original, original-wordmark, plain-wordmark) new icon: processwire (original, original-wordmark, plain-wordmark) Dec 3, 2023
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did processwire just change their logo colors?
image

I can't find the pink version on their website nor their github. @SkyLundy Do you have a link to the official logo by any chance? The only ones I official could find were blue and white

@SkyLundy
Copy link
Author

Screenshot from 2023-12-11 09-03-21

@Snailedlt Both colors have been used in different locations, so I talked to the ProcessWire repo owner & primary developer @ryancramerdesign who confirmed the blue featured on the website is a good choice. I've pushed that change in the latest commit.

Copy link
Contributor

github-actions bot commented Mar 7, 2024

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60


Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

Copy link
Member

@canaleal canaleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All is good 👍
Optimized the SVGs using SVGOMG and updated the color in the json to the processwire blue.

Looks good on icomoon:
image

@canaleal canaleal requested review from a team, ConX, weh and lunatic-fox and removed request for a team September 28, 2024 02:38
Copy link
Contributor

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60


Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

@canaleal canaleal dismissed Snailedlt’s stale review November 17, 2024 07:58

All remaining issues have been resolved. The SVGs look great and the font SVGs have no artifacts when coverted with ICOMOON.

@canaleal canaleal merged commit 96c66a3 into devicons:develop Nov 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants