Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: rockylinux (original, original-wordmark, plain, plain-wordmark) #1884

Merged
merged 5 commits into from
Nov 1, 2023

Conversation

canaleal
Copy link
Member

@canaleal canaleal commented Oct 5, 2023

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes #1827

Link to prove your SVG is correct and up-to-date.

The main color is #10b982 but I want with black for the plain icons.

Official Website: https://rockylinux.org/
Wiki: https://en.wikipedia.org/wiki/Rocky_Linux
Github: https://github.com/rocky-linux
Asset Library: https://github.com/rocky-linux/documentation/blob/main/docs/assets/rocky-linux-logo.svg

Copy link
Contributor

@weh weh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this looks good, just some missing empty lines

icons/rockylinux/rockylinux-original-wordmark.svg Outdated Show resolved Hide resolved
icons/rockylinux/rockylinux-original.svg Outdated Show resolved Hide resolved
icons/rockylinux/rockylinux-plain-wordmark.svg Outdated Show resolved Hide resolved
icons/rockylinux/rockylinux-plain.svg Outdated Show resolved Hide resolved
Copy link
Contributor

@weh weh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this looks good. @Panquesito7

icons/rockylinux/rockylinux-plain.svg Outdated Show resolved Hide resolved
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅
Thank you for the contribution! 🙏

@Snailedlt Snailedlt requested review from a team, ConX, lunatic-fox and Panquesito7 and removed request for a team October 21, 2023 21:09
@Snailedlt Snailedlt added the hacktoberfest-accepted Accepted to be counted towards Hacktoberfest label Oct 30, 2023
@Snailedlt Snailedlt added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Oct 30, 2023
@Snailedlt Snailedlt merged commit ca5903f into devicons:develop Nov 1, 2023
8 checks passed
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature:icon Use this label for pull requests when a new icon is ready to be added to the collection hacktoberfest-accepted Accepted to be counted towards Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants