Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon : Pulumi (original) #1881

Closed

Conversation

shailendrakawadkar
Copy link

@shailendrakawadkar shailendrakawadkar commented Oct 5, 2023

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here
  • This PR closes [ICON REQUEST]: pulumi #1864

Link to prove your SVG is correct and up-to-date.

I got the SVG from the home page of their official website

@shailendrakawadkar
Copy link
Author

Hi @weh @Panquesito7 @lunatic-fox please review my PR.

@weh
Copy link
Contributor

weh commented Oct 5, 2023

i am not (yet) a official maintainer, but it looks like #1882 and you had a race :)
#1882 looks more complete with more variants of the logo. so i would prefer to close this PR and stick with #1882

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants