Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: supabase (original, original-wordmark, plain, plain-wordmark) #1762

Merged
merged 7 commits into from
May 23, 2023

Conversation

PantheraRed
Copy link
Contributor

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes NONE
#952

Link to prove your SVG is correct and up-to-date.

https://supabase.com/
https://supabase.com/brand-assets

@Panquesito7 Panquesito7 added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label May 16, 2023
devicon.json Outdated
"versions": {
"svg": [
"original",
"original-wordmark"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add these to the font versions, or create a font version of the icon.
Let us know if you need any help with that. 🙂

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was having some trouble while making them so I thought I'd do them after the pull request.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @Panquesito7 :)
If you're really fast you'll get them in the upcoming release

devicon.json Outdated Show resolved Hide resolved
Co-authored-by: David Leal <[email protected]>
Panquesito7
Panquesito7 previously approved these changes May 20, 2023
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🚀

image

image

Copy link
Contributor

@lunatic-fox lunatic-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove some modifications not related to this entry in devicon.json.

devicon.json Outdated Show resolved Hide resolved
devicon.json Outdated Show resolved Hide resolved
Copy link
Contributor

@lunatic-fox lunatic-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect icons and great work! ✔
Thank you for this contribution! 🚀

@Panquesito7
Copy link
Member

Remove some modifications not related to this entry in devicon.json.

Should I fix those by committing directly or?

@Panquesito7 Panquesito7 changed the title new icon: supabase (original, original-wordmark) new icon: supabase (original, original-wordmark, plain, plain-wordmark) May 23, 2023
@Panquesito7 Panquesito7 merged commit 3802ad6 into devicons:develop May 23, 2023
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants