Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: trpc (original, original-wordmark, plain, plain-wordmark) #1742

Merged
merged 9 commits into from
Apr 28, 2023

Conversation

sinuheshinbr
Copy link
Contributor

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes #1732

Link to prove your SVG is correct and up-to-date.

https://trpc.io/

sinuheshinbr and others added 3 commits April 23, 2023 21:08
- Add `altnames` to `trpc` entry
- Remove trailing comma at `tags`
- Remove `fill-rule` of icons
Copy link
Contributor

@lunatic-fox lunatic-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello there! 👋🏼
The icons are pretty good, but they are different from the official logos, please consider to use the listed below to base the new icons.

original

original-wordmark

Remember to choose only one original-wordmark version.

With this change plain and plain-wordmark will need to be new monocolor icons.

In devicon.json the versions property should be like:

        "versions": {
            "svg": [
                "original",
                "original-wordmark",
                "plain",
                "plain-wordmark"
            ],
            "font": [
                "plain",
                "plain-wordmark"
            ]
        },

@lunatic-fox lunatic-fox changed the title new icon: tRPC (original, original-wordmark) new icon: trcp (original, original-wordmark) Apr 25, 2023
sinuheshinbr and others added 2 commits April 25, 2023 15:38
- Unify `plain-wordmark` paths
- Remove `fill` color from `plain` and `plain-wordmark`
@lunatic-fox lunatic-fox added feature:icon Use this label for pull requests when a new icon is ready to be added to the collection bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Apr 25, 2023
@lunatic-fox
Copy link
Contributor

Thank you for the fast response! 🚀

Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there. Just a few suggestions :)

devicon.json Outdated Show resolved Hide resolved
devicon.json Show resolved Hide resolved
@Snailedlt Snailedlt added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger bot:check Use this label to trigger check-bot. Remove and re-add the label to re-trigger labels Apr 26, 2023
@Snailedlt Snailedlt changed the title new icon: trcp (original, original-wordmark) new icon: trcp (original, original-wordmark, plain, plain-wordmark) Apr 26, 2023
sinuheshinbr and others added 3 commits April 26, 2023 15:11
@lunatic-fox lunatic-fox added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Apr 26, 2023
@Panquesito7 Panquesito7 added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Apr 28, 2023
@lunatic-fox lunatic-fox changed the title new icon: trcp (original, original-wordmark, plain, plain-wordmark) new icon: trpc (original, original-wordmark, plain, plain-wordmark) Apr 28, 2023
@lunatic-fox lunatic-fox added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Apr 28, 2023
@lunatic-fox
Copy link
Contributor

Sorry, I made a little mistake on icon name. Fixed!

@Panquesito7
Copy link
Member

It appears the screenshot won't be sent due that the workflow is being taken from the master branch, and the workflows are still using the Ubuntu 18.04 image, which is no longer supported in GitHub Actions.
We can manually upload these icons to Icomoon and see the results, though.

https://github.com/devicons/devicon/actions/runs/4832860711

Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks! 🚀

image
image

P.S.: we will need to make a release ASAP.

@lunatic-fox
Copy link
Contributor

lunatic-fox commented Apr 28, 2023

It appears the screenshot won't be sent due that the workflow is being taken from the master branch, and the workflows are still using the Ubuntu 18.04 image, which is no longer supported in GitHub Actions. We can manually upload these icons to Icomoon and see the results, though.

https://github.com/devicons/devicon/actions/runs/4832860711

Yes, I made a note on #1731.

Copy link
Contributor

@lunatic-fox lunatic-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Everything looks fine! ✔
Thank you for this contribution! 🚀

@Panquesito7 Panquesito7 merged commit d8f4c48 into devicons:develop Apr 28, 2023
@sinuheshinbr sinuheshinbr deleted the feature/trpc branch April 28, 2023 20:19
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:check Use this label to trigger check-bot. Remove and re-add the label to re-trigger bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants