-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new icon: trpc (original, original-wordmark, plain, plain-wordmark) #1742
Conversation
- Add `altnames` to `trpc` entry - Remove trailing comma at `tags` - Remove `fill-rule` of icons
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello there! 👋🏼
The icons are pretty good, but they are different from the official logos, please consider to use the listed below to base the new icons.
original
original-wordmark
Remember to choose only one
original-wordmark
version.
With this change plain
and plain-wordmark
will need to be new monocolor icons.
In devicon.json
the versions
property should be like:
"versions": {
"svg": [
"original",
"original-wordmark",
"plain",
"plain-wordmark"
],
"font": [
"plain",
"plain-wordmark"
]
},
- Unify `plain-wordmark` paths - Remove `fill` color from `plain` and `plain-wordmark`
Thank you for the fast response! 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there. Just a few suggestions :)
Co-authored-by: Jørgen Kalsnes Hagen <[email protected]>
Co-authored-by: Jørgen Kalsnes Hagen <[email protected]>
Sorry, I made a little mistake on icon name. Fixed! |
It appears the screenshot won't be sent due that the workflow is being taken from the https://github.com/devicons/devicon/actions/runs/4832860711 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I made a note on #1731. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Everything looks fine! ✔
Thank you for this contribution! 🚀
Double check these details before you open a PR
develop
branch.devicon.json
file as seen hereThis PR closes #1732
Link to prove your SVG is correct and up-to-date.
https://trpc.io/