Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: stackoverflow (original, original-wordmark, plain, plain-wordmark, line, line-wordmark) #1511

Merged
merged 8 commits into from
Feb 17, 2023

Conversation

Panquesito7
Copy link
Member

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes #1223

Link to prove your SVG is correct and up-to-date.

https://stackoverflow.design/brand/logo/

@Panquesito7 Panquesito7 added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Nov 17, 2022
@Panquesito7 Panquesito7 linked an issue Nov 17, 2022 that may be closed by this pull request
1 task
Copy link
Contributor

@lunatic-fox lunatic-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello there!
You'll need to do a few things to the icons:

To all icons

  • Release clip paths
    • In Inkscape:
      • In Layers and Objects tab
        • Right click the grouped paths clip-path-icon
        • Select: Release Clip
      • This action will open two paths
        • Remove the clip path.

To plain and plain-wordmark versions

devicon.json Outdated Show resolved Hide resolved
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things to fix:

  • Paths need to be unified for plain icons
  • width and height attributes should be removed

Optional

  • Consider adding a line version

icons/stackoverflow/stackoverflow-original.svg Outdated Show resolved Hide resolved
icons/stackoverflow/stackoverflow-plain-wordmark.svg Outdated Show resolved Hide resolved
...path for the font versions.
@lunatic-fox lunatic-fox added the bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger label Feb 15, 2023
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images Imgur Images Imgur Images Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images Imgur Images Imgur Images Imgur Images

Here are the colored versions:
Imgur Images Imgur Images Imgur Images Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

@Panquesito7 Panquesito7 changed the title new icon: stackoverflow (original, original-wordmark, plain, plain-wordmark) new icon: stackoverflow (original, original-wordmark, plain, plain-wordmark, line, line-wordmark) Feb 15, 2023
Copy link
Contributor

@lunatic-fox lunatic-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! ✔
Thank you for this contribution! 🚀

@Panquesito7
Copy link
Member Author

Great! ✔ Thank you for this contribution! 🚀

Thanks for your help and reviews. :)

@Snailedlt Snailedlt added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Feb 17, 2023
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images Imgur Images Imgur Images Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images Imgur Images Imgur Images Imgur Images

Here are the colored versions:
Imgur Images Imgur Images Imgur Images Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

@Snailedlt Snailedlt merged commit ccd2a89 into develop Feb 17, 2023
@Panquesito7 Panquesito7 deleted the add_stackoverflow branch February 20, 2023 22:23
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ICON REQUEST]: Stackoverflow
3 participants