only check stroke for icons in devicon.json's font objects #1491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
@BenSouchet Finally got around to adding this. Take a look if you'd like :) |
Snailedlt
added
enhancement
devops
|
|
Panquesito7
approved these changes
Feb 8, 2023
|
@lunatic-fox you've gained a bit of python knowledge lately. I would appreciate a review from you when you have time :) |
ConX
approved these changes
Mar 30, 2023
|
Will be merging in a few days if no new reviews are made. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Double check these details before you open a PR
Features
This PR closes #1325
Notes
Tested by pushing to master in my fork, then making a PR with an original icon containing the
strokeattribute, and changing which icons are listed inside devicon.json'sfontobject.Here's the PR I tested: Snailedlt#63