new icon: hadoop (original, original-wordmark, plain, plain-wordmark) #1488

MAGistR-bit · 2022-10-30T07:35:52Z

Apache Hadoop

Opened the pull request (again)

Fix issue with npm publish script

Build preparation for release v2.15.1

The following actions were performed: * Updated devicon.json * Various versions of the icon have been added

The following changes have been made: * Updated the json file * Renamed the file * Deleted the file (hadoop-original-wordmark.svg)

The following changes have been made: * Optimized the images (SVG) * Merged the paths (for plain and line icons) into one

The following changes have been made: * Deleted extra files * Updated the file

Update devicon.json

Co-authored-by: Jørgen Kalsnes Hagen <[email protected]>

Edited the color of the image

MAGistR-bit · 2022-10-30T07:48:13Z

@Snailedlt I have opened a new pull request (PR).

github-actions · 2022-10-30T19:51:26Z

Hi!

I'm the check-bot and we have some issues with your PR:

SVG Error in 'hadoop-original.svg':
- SVG contains `stroke` property. This will get ignored by Icomoon. Please convert them to fills.

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

github-actions · 2022-10-30T19:53:27Z

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:

Here are the zoomed-in screenshots of the added icons as SVGs:

Here are the icons that will be generated by Icomoon:

Here are the zoomed-in screenshots of the added icons as icons:

Here are the colored versions:

The maintainers will now check for:

The number of Glyphs matches the number of SVGs that were selected.
The icons (second group of pictures) look the same as the SVGs (first group of pictures).
The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

Snailedlt

Looks good! ✔️
Thank you for your contribution, and your patience! 💯

PS: The bot message saying that 'stroke' should be replaced by 'fill' can be ignored, since the hadoop-original icon isn't used on icomoon as explained in this issue: #1325

devicon.json

lunatic-fox · 2022-12-06T22:59:07Z

Remastered icons

original old

original new

plain old

plain new

New icons

original-wordmark

plain-wordmark

Source: https://svn.apache.org/repos/asf/comdev/project-logos/originals/hadoop.svg

Snailedlt · 2022-12-07T09:07:50Z

Seems like this PR has become stale.

@lunatic-fox Feel free to commit the icons you suggested here, and take over the PR :)

github-actions · 2022-12-07T09:49:06Z

Hi!

I'm the check-bot and we have some issues with your PR:

SVG Error in 'hadoop-original-wordmark.svg':
- SVG contains `stroke` property. This will get ignored by Icomoon. Please convert them to fills.

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

Snailedlt · 2022-12-07T09:50:12Z

@lunatic-fox Ignore this message
ref: #1488 (review)

Snailedlt

LGTM! 💯

lunatic-fox · 2022-12-07T09:52:29Z

@lunatic-fox Ignore this message ref: #1488 (review)

Better remove it anyway, don't you think?

Snailedlt · 2022-12-07T09:53:20Z

@lunatic-fox Ignore this message ref: #1488 (review)

Better remove it anyway, don't you think?

No need imo. Well if it gets the file size down without changing the icon, then sure, otherwise we can just keep it :)

lunatic-fox · 2022-12-07T09:56:50Z

@lunatic-fox Ignore this message ref: #1488 (review)

Better remove it anyway, don't you think?

No need imo. Well if it gets the file size down without changing the icon, then sure, otherwise we can just keep it :)

It's a little stroke from the original icon. Don't know why is there, because it doesn't appear, but in order to prevent any resize bug (like it for some reason don't resize with the icon) I'll remove it really fast. 🙂

github-actions · 2022-12-07T10:05:43Z

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:

Here are the zoomed-in screenshots of the added icons as SVGs:

Here are the icons that will be generated by Icomoon:

Here are the zoomed-in screenshots of the added icons as icons:

Here are the colored versions:

The maintainers will now check for:

The number of Glyphs matches the number of SVGs that were selected.
The icons (second group of pictures) look the same as the SVGs (first group of pictures).
The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

amacado and others added 14 commits March 22, 2022 22:31

Merge pull request devicons#1084 from devicons/develop

e7a43b9

Fix issue with npm publish script

bump npm version to v2.15.1

619c806

Merge pull request devicons#1085 from devicons/draft-release

1119b9f

Build preparation for release v2.15.1

new icon: hadoop (original, original-wordmark, line)

a28d5ad

The following actions were performed: * Updated devicon.json * Various versions of the icon have been added

new icon: hadoop (original, original-wordmark, line)

54e70d2

The following actions were performed: * Updated devicon.json * Various versions of the icon have been added

new icon: original, plain

15debb6

The following changes have been made: * Updated the json file * Renamed the file * Deleted the file (hadoop-original-wordmark.svg)

new icon: original, plain

abef6b8

The following changes have been made: * Optimized the images (SVG) * Merged the paths (for plain and line icons) into one

Fixed the merge conflict

87bf329

new icon: hadoop (original, plain)

ba085d5

The following changes have been made: * Deleted extra files * Updated the file

new icon: hadoop (original, plain)

54cf51b

Update devicon.json

Update devicon.json

3fe73e8

Co-authored-by: Jørgen Kalsnes Hagen <[email protected]>

Update hadoop-original.svg

41acce1

Edited the color of the image

fix devicon.json formatting

b885408

fix devicon.json formatting (again)

58daa78

Snailedlt added the bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger label Oct 30, 2022

Snailedlt previously approved these changes Oct 30, 2022

View reviewed changes

Snailedlt mentioned this pull request Oct 30, 2022

[BUG] check-bot check -original icons even when they won't be added to icomoon #1325

Open

1 task

Snailedlt requested a review from Panquesito7 October 30, 2022 20:24

Snailedlt added the hacktoberfest-accepted Accepted to be counted towards Hacktoberfest label Oct 31, 2022

lunatic-fox reviewed Nov 8, 2022

View reviewed changes

devicon.json Outdated Show resolved Hide resolved

Snailedlt added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Dec 7, 2022

devicons deleted a comment from github-actions bot Dec 7, 2022

Add remastered icons

64c5bd6

lunatic-fox dismissed Snailedlt’s stale review via 64c5bd6 December 7, 2022 09:48

lunatic-fox changed the title ~~new icon: hadoop (original, plain)~~ new icon: hadoop (original, original-wordmark, plain, plain-wordmark) Dec 7, 2022

Snailedlt previously approved these changes Dec 7, 2022

View reviewed changes

Update hadoop-original-wordmark.svg

485923e

lunatic-fox dismissed Snailedlt’s stale review via 485923e December 7, 2022 09:57

Snailedlt approved these changes Dec 7, 2022

View reviewed changes

lunatic-fox added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Dec 7, 2022

Snailedlt merged commit fe85091 into devicons:develop Dec 10, 2022

Snailedlt mentioned this pull request Dec 10, 2022

Icon request: Apache Hadoop #584

Closed

Snailedlt mentioned this pull request Feb 5, 2024

Release v2.16.0 #2131

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

new icon: hadoop (original, original-wordmark, plain, plain-wordmark) #1488

new icon: hadoop (original, original-wordmark, plain, plain-wordmark) #1488

MAGistR-bit commented Oct 30, 2022

MAGistR-bit commented Oct 30, 2022

github-actions bot commented Oct 30, 2022

github-actions bot commented Oct 30, 2022

Snailedlt left a comment •

edited

Loading

lunatic-fox commented Dec 6, 2022

Snailedlt commented Dec 7, 2022

github-actions bot commented Dec 7, 2022

Snailedlt commented Dec 7, 2022

Snailedlt left a comment

lunatic-fox commented Dec 7, 2022

Snailedlt commented Dec 7, 2022

lunatic-fox commented Dec 7, 2022 •

edited

Loading

github-actions bot commented Dec 7, 2022

new icon: hadoop (original, original-wordmark, plain, plain-wordmark) #1488

new icon: hadoop (original, original-wordmark, plain, plain-wordmark) #1488

Conversation

MAGistR-bit commented Oct 30, 2022

Apache Hadoop

MAGistR-bit commented Oct 30, 2022

github-actions bot commented Oct 30, 2022

github-actions bot commented Oct 30, 2022

Snailedlt left a comment • edited Loading

Choose a reason for hiding this comment

lunatic-fox commented Dec 6, 2022

Remastered icons

New icons

Snailedlt commented Dec 7, 2022

github-actions bot commented Dec 7, 2022

Snailedlt commented Dec 7, 2022

Snailedlt left a comment

Choose a reason for hiding this comment

lunatic-fox commented Dec 7, 2022

Snailedlt commented Dec 7, 2022

lunatic-fox commented Dec 7, 2022 • edited Loading

github-actions bot commented Dec 7, 2022

Snailedlt left a comment •

edited

Loading

lunatic-fox commented Dec 7, 2022 •

edited

Loading