Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: cosmosdb (original, original-wordmark, plain, plain-wordmark) #1386

Merged
merged 2 commits into from
Oct 2, 2022

Conversation

Panquesito7
Copy link
Member

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes #1384

Link to prove your SVG is correct and up-to-date.

https://azure.microsoft.com/en-us/products/cosmos-db/

https://en.wikipedia.org/wiki/Cosmos_DB

@Panquesito7 Panquesito7 added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Sep 21, 2022
@Panquesito7 Panquesito7 linked an issue Sep 26, 2022 that may be closed by this pull request
1 task
@Panquesito7 Panquesito7 added the bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger label Sep 27, 2022
@github-actions

This comment was marked as outdated.

@Snailedlt
Copy link
Collaborator

@Panquesito7 Looks like the font is off in the icomoon wordmark version. Could this be because of stroke?

WARNING -- Strokes detected in the following SVGs:
cosmosdb-plain-wordmark.svg

@Panquesito7 Panquesito7 added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Sep 30, 2022
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images Imgur Images

Here are the colored versions:
Imgur Images Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat!
Thanks for another great contributions! 💯

@Snailedlt Snailedlt merged commit 0c0bbfb into develop Oct 2, 2022
@Panquesito7 Panquesito7 deleted the add_cosmos branch October 2, 2022 02:30
Snailedlt pushed a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
…k) (devicons#1386)

* new icon: cosmosdb (original, original-wordmark, plain, plain-wordmark)

* Attempt to remove strokes
Snailedlt pushed a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
…k) (devicons#1386)

* new icon: cosmosdb (original, original-wordmark, plain, plain-wordmark)

* Attempt to remove strokes
Snailedlt pushed a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
…k) (devicons#1386)

* new icon: cosmosdb (original, original-wordmark, plain, plain-wordmark)

* Attempt to remove strokes
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ICON REQUEST]: Cosmos DB
2 participants