-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new icon: materializecss (original, plain) #1363
new icon: materializecss (original, plain) #1363
Conversation
Fix issue with npm publish script
Build preparation for release v2.15.1
It's my first time contributing here, so I'm not quite sure if 100% of things are actually right. |
Oops I added the changes in AbdelrahmanDwedar:master and merged by accident!! 😵💫 That's embarrassing, sorry. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Co-authored-by: David Leal <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there! Could you please follow the steps/address what the bot mentioned earlier?
Let us know if you need any help with that here in our Discord community. 🙂
__
Summary: 🛠️ This code needs a fix | Tags: Not maintainable
I'm very sorry for the late response, I was (and still) out of internet, it'll get better next week hopefully, and the I'll continue everything needed.
I actually don't quite know how to make that icon plain, is there any recommended application or web app that could be used for that or I may just edit fhe svg file's code to set all the colors to only one? |
You just need to make a file named Let us know if you need any help! Thank you. 🙂 |
I've added the requested changes, inform me if there's anything else missing. |
This comment was marked as outdated.
This comment was marked as outdated.
Co-authored-by: David Leal <[email protected]>
Co-authored-by: David Leal <[email protected]>
Is there anything left? |
This comment was marked as outdated.
This comment was marked as outdated.
Hi there, I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here are the SVGs as intepreted by Icomoon when we upload the files: Here are the zoomed-in screenshots of the added icons as SVGs: Here are the icons that will be generated by Icomoon: Here are the zoomed-in screenshots of the added icons as icons: Here are the colored versions: The maintainers will now check for:
In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done. Thank you for contributing to Devicon! I hope that your icons are accepted into the repository. Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice. Cheers, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I resized it as requested please inform me if there's something else need to fix or check out. Also about the little tiny gap between figures in the plain version I think it makes more sense to leave as it gives you idea about the logo more. I think that gaps was already in the original one too but wasn't appearing as there's different colors in it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The icons look good visually now imo, great work!
Only thing left to do is minimize the icons, which can be done by following this guide: #1306 (comment)
I can do it if you want, just let me know
I guess that's all, not sure if I should also follow the next message after it. Is it necessary in out case or just there? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you forgot to check some options. I see there's no viewbox, please read the guide I linked again, and make sure you check the options like the guide says :)
Ohh, and the comment below can be ignored, SVGOMG does a good enough job :)
I see, I'll fix it now |
Is that all? |
Yeah, looks like that's all :) |
Hi there, I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here are the SVGs as intepreted by Icomoon when we upload the files: Here are the zoomed-in screenshots of the added icons as SVGs: Here are the icons that will be generated by Icomoon: Here are the zoomed-in screenshots of the added icons as icons: Here are the colored versions: The maintainers will now check for:
In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done. Thank you for contributing to Devicon! I hope that your icons are accepted into the repository. Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice. Cheers, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! ✔️
Thank you for a great contribution! Hope to see more PRs from you 💯
Hi there, I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here are the SVGs as intepreted by Icomoon when we upload the files: Here are the zoomed-in screenshots of the added icons as SVGs: Here are the icons that will be generated by Icomoon: Here are the zoomed-in screenshots of the added icons as icons: Here are the colored versions: The maintainers will now check for:
In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done. Thank you for contributing to Devicon! I hope that your icons are accepted into the repository. Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice. Cheers, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made some modifications, removing some hairlines. Hope that's ok! 🙂
Approved! ✔
Thank for this contribution! 🚀
Besides, seem that their SVG logo have some issues though. 🤔 |
Double check these details before you open a PR
develop
branch.devicon.json
file as seen hereThis PR closes #1345
Link to prove your SVG is correct and up-to-date.
https://materializecss.github.io/materialize/res/materialize.svg