-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new icon: json (original, plain) #1309
Conversation
Hi there, I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here are the SVGs as intepreted by Icomoon when we upload the files: Here are the zoomed-in screenshots of the added icons as SVGs: Here are the icons that will be generated by Icomoon: Here are the zoomed-in screenshots of the added icons as icons: Here are the colored versions: The maintainers will now check for:
In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done. Thank you for contributing to Devicon! I hope that your icons are accepted into the repository. Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice. Cheers, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Imo the expanded form of json (JavaScript Object Notation) should be listed as an altname.
Other than that it's a very nice and clean PR!
@Panquesito7 @Snailedlt But now (and since a while) JSON is a file format not related to JS, it's used in Python, Ruby, Go, Rust, .... Yes, originally the format was created to save / export JavaScript objects but it's simply a file format standard that as been made popular for its simplicity. and it's now used everywhere. |
@BenSouchet I have no issue with not adding javascript tag. I do find it weird to not add the long form as an altname though, even if it's not something people usually search for |
So in the current state, knowing that I already added the long form name, the PR is ready to merge ? |
Yes in my opinion, but will wait for @Panquesito7 since he suggested the other change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* Add JSON icon * add json altname as requested
* Add JSON icon * add json altname as requested
* Add JSON icon * add json altname as requested
Double check these details before you open a PR
develop
branch.devicon.json
file as seen hereThis PR closes #1303
Link to prove your SVG is correct and up-to-date.
https://upload.wikimedia.org/wikipedia/commons/c/c9/JSON_vector_logo.svg