Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: json (original, plain) #1309

Merged
merged 2 commits into from
Aug 2, 2022
Merged

new icon: json (original, plain) #1309

merged 2 commits into from
Aug 2, 2022

Conversation

BenSouchet
Copy link
Contributor

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes #1303

Link to prove your SVG is correct and up-to-date.

https://upload.wikimedia.org/wikipedia/commons/c/c9/JSON_vector_logo.svg

@Panquesito7 Panquesito7 added feature:icon Use this label for pull requests when a new icon is ready to be added to the collection bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Jul 26, 2022
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images

Here are the colored versions:
Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

Panquesito7
Panquesito7 previously approved these changes Jul 26, 2022
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! Thank you. 🚀

__
sema-logo  Summary: 🏆 This code is awesome  |  Tags: Efficient

Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Imo the expanded form of json (JavaScript Object Notation) should be listed as an altname.
Other than that it's a very nice and clean PR!

devicon.json Outdated Show resolved Hide resolved
@BenSouchet
Copy link
Contributor Author

@Panquesito7 @Snailedlt
I disagree, I was already not in favor of adding "JavaScript Object Notation" as altnames since no one will look at JSON by typing / searching JavaScript Object Notation.

But now (and since a while) JSON is a file format not related to JS, it's used in Python, Ruby, Go, Rust, ....

Yes, originally the format was created to save / export JavaScript objects but it's simply a file format standard that as been made popular for its simplicity. and it's now used everywhere.

@Snailedlt
Copy link
Collaborator

Snailedlt commented Jul 30, 2022

@BenSouchet I have no issue with not adding javascript tag. I do find it weird to not add the long form as an altname though, even if it's not something people usually search for

@BenSouchet
Copy link
Contributor Author

So in the current state, knowing that I already added the long form name, the PR is ready to merge ?

@Snailedlt
Copy link
Collaborator

So in the current state, knowing that I already added the long form name, the PR is ready to merge ?

Yes in my opinion, but will wait for @Panquesito7 since he suggested the other change

Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks! :)
I still think we should add the javascript tag, but it is fine as-is.

__
sema-logo  Summary: 👌 This code looks good  |  Tags: Maintainable

@Snailedlt Snailedlt merged commit feac41b into devicons:develop Aug 2, 2022
Snailedlt pushed a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
* Add JSON icon

* add json altname as requested
Snailedlt pushed a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
* Add JSON icon

* add json altname as requested
Snailedlt pushed a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
* Add JSON icon

* add json altname as requested
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants