Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: apachespark (original, original-wordmark, plain, plain-wordmark) #1261

Merged
merged 3 commits into from
Aug 6, 2022

Conversation

luizcarloscf
Copy link
Contributor

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes #583

Link to prove your SVG is correct and up-to-date.

https://spark.apache.org/images/
https://spark.apache.org/

devicon.json Show resolved Hide resolved
icons/apachespark/apachespark-plain.svg Outdated Show resolved Hide resolved
icons/apachespark/apachespark-plain-wordmark.svg Outdated Show resolved Hide resolved
@Snailedlt
Copy link
Collaborator

@luizcarloscf please take a look at my suggested changes when you have time :)

@Snailedlt Snailedlt added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Jul 28, 2022
@Snailedlt
Copy link
Collaborator

@luizcarloscf bump :)

@luizcarloscf
Copy link
Contributor Author

I kind of forgot about it, I'll go through the proposed changes this weekend

@Snailedlt Snailedlt added the bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger label Aug 1, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2022

Hi there,

I'm Devicons' Peek Bot and it seems we've ran into a problem.

util.find_object_added_in_pr: Couldn't find an icon matching the name in the PR title.
PR title is: ' new icon: apachespark (original, original-wordmark, plain, plain-wordmark)'

Make sure that:

  • Your svgs are named and added correctly to the /icons folder as seen here.
  • Your icon information has been added to the devicon.json as seen here
  • Your PR title follows the format seen here

I will retry once everything is fixed. If I still fail or there are other error, the maintainers will investigate.

Best of luck,
Peek Bot ☺️

@Snailedlt Snailedlt changed the title new icon: apachespark (original, original-wordmark, plain, plain-wordmark) new icon: apachespark (original, original-wordmark, plain, plain-wordmark) Aug 1, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2022

Hi there,

I'm Devicons' Peek Bot and it seems we've ran into a problem.

util.find_object_added_in_pr: Couldn't find an icon matching the name in the PR title.
PR title is: ' new icon: apachespark (original, original-wordmark, plain, plain-wordmark)'

Make sure that:

  • Your svgs are named and added correctly to the /icons folder as seen here.
  • Your icon information has been added to the devicon.json as seen here
  • Your PR title follows the format seen here

I will retry once everything is fixed. If I still fail or there are other error, the maintainers will investigate.

Best of luck,
Peek Bot ☺️

@Snailedlt Snailedlt added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Aug 1, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2022

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images Imgur Images

Here are the colored versions:
Imgur Images Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✔️
Thank you for your contribution! 🙇

Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✔️
Thank you for your contribution! 🙇

@Snailedlt Snailedlt merged commit 623b69f into devicons:develop Aug 6, 2022
Snailedlt pushed a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
…mark) (devicons#1261)

* Add Apache Spark icons. Closes devicons#583

* Add altnames in devicon.json

* Combine paths in plain versions
Snailedlt pushed a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
…mark) (devicons#1261)

* Add Apache Spark icons. Closes devicons#583

* Add altnames in devicon.json

* Combine paths in plain versions
Snailedlt pushed a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
…mark) (devicons#1261)

* Add Apache Spark icons. Closes devicons#583

* Add altnames in devicon.json

* Combine paths in plain versions
@luizcarloscf luizcarloscf deleted the 583-apachespark-icons branch May 21, 2023 00:32
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants