-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new icon: apachespark (original, original-wordmark, plain, plain-wordmark) #1261
new icon: apachespark (original, original-wordmark, plain, plain-wordmark) #1261
Conversation
@luizcarloscf please take a look at my suggested changes when you have time :) |
@luizcarloscf bump :) |
I kind of forgot about it, I'll go through the proposed changes this weekend |
Hi there, I'm Devicons' Peek Bot and it seems we've ran into a problem.
Make sure that:
I will retry once everything is fixed. If I still fail or there are other error, the maintainers will investigate. Best of luck, |
Hi there, I'm Devicons' Peek Bot and it seems we've ran into a problem.
Make sure that:
I will retry once everything is fixed. If I still fail or there are other error, the maintainers will investigate. Best of luck, |
Hi there, I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here are the SVGs as intepreted by Icomoon when we upload the files: Here are the zoomed-in screenshots of the added icons as SVGs: Here are the icons that will be generated by Icomoon: Here are the zoomed-in screenshots of the added icons as icons: Here are the colored versions: The maintainers will now check for:
In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done. Thank you for contributing to Devicon! I hope that your icons are accepted into the repository. Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice. Cheers, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! ✔️
Thank you for your contribution! 🙇
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! ✔️
Thank you for your contribution! 🙇
…mark) (devicons#1261) * Add Apache Spark icons. Closes devicons#583 * Add altnames in devicon.json * Combine paths in plain versions
…mark) (devicons#1261) * Add Apache Spark icons. Closes devicons#583 * Add altnames in devicon.json * Combine paths in plain versions
…mark) (devicons#1261) * Add Apache Spark icons. Closes devicons#583 * Add altnames in devicon.json * Combine paths in plain versions
Double check these details before you open a PR
develop
branch.devicon.json
file as seen hereThis PR closes #583
Link to prove your SVG is correct and up-to-date.
https://spark.apache.org/images/
https://spark.apache.org/