Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: unifiedmodelinglanguage (original, original-wordmark, plain, plain-wordmark) #1241

Merged
merged 7 commits into from
Aug 7, 2022

Conversation

kilianpaquier
Copy link
Contributor

@kilianpaquier kilianpaquier commented Jun 28, 2022

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR contributes to #104

Link to prove your SVG is correct and up-to-date.

https://en.wikipedia.org/wiki/Unified_Modeling_Language

@Snailedlt Snailedlt added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Jul 28, 2022
devicon.json Outdated Show resolved Hide resolved
devicon.json Show resolved Hide resolved
devicon.json Show resolved Hide resolved
Co-authored-by: Jørgen Kalsnes Hagen <[email protected]>
@Snailedlt Snailedlt added the bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger label Aug 6, 2022
@Snailedlt
Copy link
Collaborator

Sorry about all the confusion. I guess I was a little blind when I last checked the colors here 😅

@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2022

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images Imgur Images

Here are the colored versions:
Imgur Images Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patience and the contribution! 🙇 🚀

Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing! 🎉

__
sema-logo  Summary: 👌 This code looks good  |  Tags: Maintainable

@Panquesito7 Panquesito7 merged commit 9293435 into devicons:develop Aug 7, 2022
@kilianpaquier kilianpaquier deleted the uml branch August 18, 2022 17:27
Snailedlt added a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
…, plain-wordmark) (devicons#1241)

* new icon: unifiedmodelinglanguage (original, original-wordmark, plain, plain-wordmark) - contributes devicons#104

* uml| fix tag language

* uml| renamed svg and folder to full name

* Apply suggestions from code review

Co-authored-by: Jørgen Kalsnes Hagen <[email protected]>

Co-authored-by: Jørgen Kalsnes Hagen <[email protected]>
Snailedlt added a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
…, plain-wordmark) (devicons#1241)

* new icon: unifiedmodelinglanguage (original, original-wordmark, plain, plain-wordmark) - contributes devicons#104

* uml| fix tag language

* uml| renamed svg and folder to full name

* Apply suggestions from code review

Co-authored-by: Jørgen Kalsnes Hagen <[email protected]>

Co-authored-by: Jørgen Kalsnes Hagen <[email protected]>
Snailedlt added a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
…, plain-wordmark) (devicons#1241)

* new icon: unifiedmodelinglanguage (original, original-wordmark, plain, plain-wordmark) - contributes devicons#104

* uml| fix tag language

* uml| renamed svg and folder to full name

* Apply suggestions from code review

Co-authored-by: Jørgen Kalsnes Hagen <[email protected]>

Co-authored-by: Jørgen Kalsnes Hagen <[email protected]>
@Lorenzo501
Copy link

Consider simplifying it somewhat. The symbol about the trademark being registered (R) and (TM) isn't really necessary. Devicon also has no other icons with those symbols as far as I'm aware. People can search for the trademark registration when they need to know that information. The rest is fine in my opinion.

@Snailedlt
Copy link
Collaborator

@Lorenzo501 There's quite a few icons with trademark symbols now, though admittedly not that many on the master branch. I think leaving in the trademark symbol is fine, so long as the file doesn't get huge as a result of it ofc.

@Lorenzo501
Copy link

Lorenzo501 commented Jan 27, 2023

@Lorenzo501 There's quite a few icons with trademark symbols now, though admittedly not that many on the master branch. I think leaving in the trademark symbol is fine, so long as the file doesn't get huge as a result of it ofc.

When people use it and they make it a little bit smaller, then you won't even be able to read the trademark symbol. It'll just be a tiny circle which then looks out of place. It's essentially not even part of the logo, so at that point it'll just be rather inconvient for those who use a smaller size logo. And so in that case they will most likely fix it themselves by not using devicon for everything, which is a bit cumbersome, I'm sure you would agree.

So I'd still suggest to remove it so that nobody will experience any issues using devicon for their website. You can see for yourself, if you decrease its size somewhat (the non-zoomed-in version), not even by a lot and I know for sure that a lot of people do this for their website, especially content for smartphones. Plus it looks a lot cleaner without it, in any case. Doing it for this one is a start. I don't know which other ones there are what you spoke about, but they can be improved too at some point.

@Snailedlt
Copy link
Collaborator

@Lorenzo501 I agree with you, I just cba to do it myself 😅 But if you want to fix it a PR would be highly appreciated :)

@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants