Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: liquibase (original, original-wordmark) #1224

Merged
merged 3 commits into from
Jun 23, 2022
Merged

new icon: liquibase (original, original-wordmark) #1224

merged 3 commits into from
Jun 23, 2022

Conversation

kilianpaquier
Copy link
Contributor

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

Link to prove your SVG is correct and up-to-date.

https://www.liquibase.org/brand (wordmark)
https://www.liquibase.org/wp-content/themes/liquibase/assets/img/cta-icon-org.svg (none-wordmark)

PS : Converted the PNG image into a SVG. I'm also not sure about the aliases, the original svg can be used for the plains version, do i need to add something to the devicon.json ?

@Panquesito7 Panquesito7 added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Jun 21, 2022
@kilianpaquier kilianpaquier changed the title new icon : Liquibase (original, original-wordmark) new icon : liquibase (original, original-wordmark) Jun 22, 2022
@kilianpaquier kilianpaquier changed the title new icon : liquibase (original, original-wordmark) new icon: liquibase (original, original-wordmark) Jun 22, 2022
@amacado amacado added the bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger label Jun 23, 2022
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images Imgur Images

Here are the colored versions:
Imgur Images Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

@amacado amacado self-requested a review June 23, 2022 08:42
Copy link
Member

@amacado amacado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kilian-paquier would you consider adding the new "altnames": [] attribute for liquidbase? https://github.com/devicons/devicon/wiki/Example-of-Submitting-Icons-to-the-Repository

thank you for the contribution!

@kilianpaquier
Copy link
Contributor Author

@kilian-paquier would you consider adding the new "altnames": [] attribute for liquidbase? https://github.com/devicons/devicon/wiki/Example-of-Submitting-Icons-to-the-Repository

thank you for the contribution!

Hello,

Will do today ! Do I need to add aliases as the original svg is also the plain svg ?

@amacado
Copy link
Member

amacado commented Jun 23, 2022

yes, you could add an alias for it following this guide https://github.com/devicons/devicon/wiki/Updating-the-%60devicon.json%60#aliases-and-aliasobj

@kilianpaquier
Copy link
Contributor Author

Hello @amacado,

Thanks for reviewing the PR. The requested change is pushed.

Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 Thank you for your contribution! 😄👍

__
sema-logo  Summary: 🏆 This code is awesome  |  Tags: Efficient

@amacado amacado merged commit fb264bc into devicons:develop Jun 23, 2022
@kilianpaquier kilianpaquier deleted the add-liquibase branch July 18, 2022 07:31
Snailedlt pushed a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
* new icon: liquibase (original, original-wordmark)

* liquibase| added altnames for liquibase to devicon.json

* liquibase| added plain alias for liquibase to devicon.json
Snailedlt pushed a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
* new icon: liquibase (original, original-wordmark)

* liquibase| added altnames for liquibase to devicon.json

* liquibase| added plain alias for liquibase to devicon.json
Snailedlt pushed a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
* new icon: liquibase (original, original-wordmark)

* liquibase| added altnames for liquibase to devicon.json

* liquibase| added plain alias for liquibase to devicon.json
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants