Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix directory structure for Haskell icon #274

Closed
amacado opened this issue Sep 1, 2020 · 0 comments · Fixed by #275
Closed

Fix directory structure for Haskell icon #274

amacado opened this issue Sep 1, 2020 · 0 comments · Fixed by #275
Assignees
@amacado
Labels
bug Use this label for pointing out bugs request:icon When requesting a new icon to be added to the collection or a refactor use this label in your issue

Comments

@amacado
Copy link
Member

amacado commented Sep 1, 2020

As pointed out by @Thomas-Boi in pull request 268 the directory structure for the Haskell icon does not follow our guidelines. The error was made back in the pull request 107.

Also the Haskell icon is not added into the font yet.
@amacado amacado added bug Use this label for pointing out bugs request:icon When requesting a new icon to be added to the collection or a refactor use this label in your issue labels Sep 1, 2020
@amacado amacado self-assigned this Sep 1, 2020
@amacado amacado mentioned this issue Sep 1, 2020
Merged
amacado added a commit that referenced this issue Sep 1, 2020
@amacado
move haskell to fonts/ directory (issue #274) and rework plain-versio…
0a17790 
…ns to prepare for use as font; adding haskell to devicon.json and devicon-colors.css
@amacado amacado closed this as completed in 40537e7 Sep 1, 2020
@amacado amacado linked a pull request Sep 1, 2020 that will close this issue
New Icon: Haskell (original, plain, wordmark) (fixes #274) #275
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amacado amacado

Labels
bug Use this label for pointing out bugs request:icon When requesting a new icon to be added to the collection or a refactor use this label in your issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

New Icon: Haskell (original, plain, wordmark) (fixes #274) devicons/devicon
1 participant
@amacado