Skip to content

Commit

Permalink
Added __pycache__ to gitignore and documented geckodriver.exe
Browse files Browse the repository at this point in the history
  • Loading branch information
Thomas-Boi committed Sep 2, 2020
1 parent 83378fa commit f839169
Show file tree
Hide file tree
Showing 8 changed files with 8 additions and 118 deletions.
6 changes: 3 additions & 3 deletions .github/scripts/build_assets/SeleniumRunner.py
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ def set_options(self, geckodriver_path: str, headless: bool):

def upload_icomoon(self):
"""
Upload the icomoon_test.json to icomoon.io.
Upload the icomoon.json to icomoon.io.
:raises TimeoutException: happens when elements are not found.
"""
print("Uploading JSON file...")
Expand All @@ -100,8 +100,8 @@ def upload_icomoon(self):
confirm_btn.click()
except SeleniumTimeoutException as e:
print(e.stacktrace)
print("Cannot find the confirm button when uploading the icomoon_test.json",
"Ensure that the icomoon_test.json is in the correct format for Icomoon.io",
print("Cannot find the confirm button when uploading the icomoon.json",
"Ensure that the icomoon.json is in the correct format for Icomoon.io",
sep='\n')
self.close()

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
This folder was taken from: https://github.com/mozilla/geckodriver/releases/tag/v0.27.0
Binary file not shown.
Binary file removed .github/scripts/build_assets/geckodriver.exe
Binary file not shown.
3 changes: 2 additions & 1 deletion .github/workflows/build_icons.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,8 @@ jobs:
pip install -r ./.github/scripts/requirements.txt
- name: Run icomoon_upload.py
run: >
python ./.github/scripts/icomoon_upload.py ./.github/scripts/build_assets/geckodriver.exe
python ./.github/scripts/icomoon_upload.py
./.github/scripts/build_assets/geckodriver-v0.27.0-win64/geckodriver.exe
./icomoon.json ./devicon.json ./icons ./built_files --headless
- name: Commit changes
uses: stefanzweifel/git-auto-commit-action@v4
Expand Down
3 changes: 2 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
node_modules
.DS_Store
.idea
geckodriver.log
geckodriver.log
__pycache__
39 changes: 0 additions & 39 deletions upgrade_assets/deviconColorsParser.js

This file was deleted.

74 changes: 0 additions & 74 deletions upgrade_assets/parseInput.js

This file was deleted.

0 comments on commit f839169

Please sign in to comment.