Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Drupal 8.5 #24

Merged
merged 19 commits into from
Feb 21, 2018
Merged

Support Drupal 8.5 #24

merged 19 commits into from
Feb 21, 2018

Conversation

deviantintegral
Copy link
Owner

@deviantintegral deviantintegral commented Feb 19, 2018 •
edited
Loading

Highlights include:

@deviantintegral deviantintegral mentioned this pull request Feb 19, 2018
Closed
@deviantintegral
Copy link
Owner Author

I also need to note that this upgrades to PHPUnit 6.

juampynr
juampynr reviewed Feb 21, 2018
View reviewed changes
hooks/RoboFile.php
$admin_password = null,
$site_name = null
public function setupDrupal($opts = [
'admin-user' => null,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@juampynr juampynr merged commit 3959b8a into master Feb 21, 2018
@juampynr juampynr deleted the drupal-85 branch February 21, 2018 10:10
m4olivei
m4olivei reviewed Feb 21, 2018
View reviewed changes
hooks/test-js.sh

if [ $? -gt 0 ]
then
echo 'Behat tests failed. The last 100 lines of the access log are:'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is neat!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m4olivei m4olivei m4olivei left review comments

@juampynr juampynr juampynr left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deviantintegral @juampynr @m4olivei