Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go-librespot works with driver that support C.SND_PCM_FORMAT_FLOAT_LE only #160

Open
pilollipietro opened this issue Jan 13, 2025 · 3 comments
Labels
enhancement New feature or request

Comments

@pilollipietro
Copy link

I'm using C.SND_PCM_FORMAT_S16_LE

I attach here code to support it. The patch must be applied to git tag v0.1.3.
go-librespot-SND_PCM_FORMAT_S16_LE.patch.txt

@devgianlu devgianlu added the enhancement New feature or request label Jan 16, 2025
@devgianlu
Copy link
Owner

You are welcome to make a PR to merge this into the codebase! If you can't/don't want to do it let me know and I'll merge it.

@pilollipietro
Copy link
Author

pilollipietro commented Jan 20, 2025

go-librespot-SND_PCM_FORMAT_S16_LE.patch.txt

Honestly, it's the first patch I've made in go and I don't know rust, I use git for work but I've never used github. I would prefer in the first instance if you can that you did it yourself. Place the patch aligned to the current master

@devgianlu
Copy link
Owner

I have created a PR with your changes, but I had to change the code a little bit and now it does not seem to work. Specifically, errors from configureAdaptiveBuffer were not handled and now it seems to fail there. Can you have a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants